From nobody Sat Jul 08 14:14:09 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Qyshy0z9Dz4lqJK for ; Sat, 8 Jul 2023 14:14:42 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Qyshy0Mqqz3kd6; Sat, 8 Jul 2023 14:14:42 +0000 (UTC) (envelope-from dim@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688825682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D/9nOxV3XSqlcvhjaGH0tZbFDxL8jhIHY66WQDnAOFo=; b=YKvRCGju5X8toSq3M/yPzZjp1RNW5QwAMVFuIuSAX7HJCCWLcxPpvWosy7RJkmjVVqyqOt xBsSA/BiQgVgFtcGp87dt23WJ2jOTLwWEkvttdsfJcwvauwyRxxdgf7jT6fvXNUVrTkOB4 KuT0leFnOVZcCRLtAS7URb4Ld0gWw8kn/TY2JEVocpIVkCalQU4uu4Q1N55pZlW4b+57yl djXmOD3GGQl27wShfhcKnPPoyYSO/TCJwsXIrb30iX4FUnhWKkubMJ7valqG5Y9c6ho/EZ rON9JIzgMQVNDTlWluDFAl2tgXVdFjRtVvL+VTr+WNF2zOaQSXWhn6bmGNlmxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688825682; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D/9nOxV3XSqlcvhjaGH0tZbFDxL8jhIHY66WQDnAOFo=; b=yJrh+qTKe0vkdNlrHmuke4BLE1GxZs+frlIPSGRtC89eSlz07BXLIj3rNqzjd7mWm0zPPj KhjrIvmTUL1N2J1Hift1zH1g8Afn0z6qP0pk6UxifZim6/vrUUcG1xqxYJHidh9A7hQ5CG XBthgnmmqpPTR6iWYz7tzz5owTMR6usPIJmK4JhfsxAjCwnqFfuffnH8HA5ywZ7SdHKtaw aq7NVsJqm9lBdXiJe4RCqUjhk84d+YeBpYbUY1fCeIF8O5Z20ABDwJjwOVzCXcRsnujLAm 2B+1KeATWpp1BjpuFUsdu3C1fE9XcBn4MFFo4dnaAJc9NLedbh0UpqevOChnOg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688825682; a=rsa-sha256; cv=none; b=ZGBLckIQY71CNsPq5aKBdmlBn+GzgI1uD/5b0DBFUb+DiE7RfQuup14I2Y5tl+28QkPZdR 2HgQBQz33/Yusgg+pEKp2h9g3uCEE5USLMUQtexFAXl4w7L3Zby5S+iOjteKWjNq8KgBp6 FDqfUzHNZnRKXwBUwYK6L2n9VpnvOE5Mdqk25GcGQ04W9sKgzVzg06oq9ljBTOd3jzm2ev UNfqaEhFTR0DShEdfPj+ZHeAn8eD3u7HLyPf3/6u/Mcq9ssqL1CR7loJvJ+V1XFKeleCAz rm2YlaPxK5froEjdnzOueyXc/076IhSHrsj29JMo2DCQZwTO3RTiVEjMAqJmjQ== Received: from tensor.andric.com (tensor.andric.com [87.251.56.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "tensor.andric.com", Issuer "R3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Qyshx5pYRz1Bgj; Sat, 8 Jul 2023 14:14:41 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtpclient.apple (longrow.home.andric.com [192.168.0.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 6D6A84BC45; Sat, 8 Jul 2023 16:14:38 +0200 (CEST) Content-Type: multipart/signed; boundary="Apple-Mail=_48783415-2CE9-44F5-A5FA-32265E709543"; protocol="application/pgp-signature"; micalg=pgp-sha1 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: clang-tidy not part of base From: Dimitry Andric In-Reply-To: Date: Sat, 8 Jul 2023 16:14:09 +0200 Cc: FreeBSD Mailing List Message-Id: References: To: Nuno Teixeira X-Mailer: Apple Mail (2.3731.600.7) X-ThisMailContainsUnwantedMimeParts: N --Apple-Mail=_48783415-2CE9-44F5-A5FA-32265E709543 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 8 Jul 2023, at 14:38, Nuno Teixeira wrote: >=20 > Recently deskutils/treesheets upstream introduced clang-tidy to cmake: > --- > set(CMAKE_CXX_CLANG_TIDY clang-tidy = -checks=3Dcppcoreguidelines-*,clang-analyzer-*,readability-*,performance-*= ,portability-*,concurrency-*,modernize-*) > --- > = https://github.com/aardappel/treesheets/blob/9131048804169c448ba61900935ff= 04acfb1e279/CMakeLists.txt#L63C13-L63C13 >=20 > This causing build to fail because clang-tidy is not found. > What I found is that 13 and 14 doesn't ship this program but it is = available as clang-tidy{13,15} from llvm ports. Theoretically we could import clang-tidy into base, at least the parts = that don't use Python, but it is better left in the llvm ports. > As workaround I comment it out. > Any sugestions on what to do, what to say to upstream? >=20 > Should this be a cmake debug option? I guess that clang-tidy is used by the upstream maintainers, for = cleaning up the source, but it is of no use to ports builders or package = end-users. For the short term, I would simply comment it out. I would inform = upstream that this can be problematic, and maybe put it under some sort = of "enable-maintainer-mode" option? -Dimitry --Apple-Mail=_48783415-2CE9-44F5-A5FA-32265E709543 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCZKlvMgAKCRCwXqMKLiCW o818AJ9c7QO/V/7p0TTwX38kLkJ1OhxDDQCg3Z4i9Xm1oHU6ITpJs7rfyRiCN3s= =lwBj -----END PGP SIGNATURE----- --Apple-Mail=_48783415-2CE9-44F5-A5FA-32265E709543--