From nobody Wed Jul 05 00:26:49 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QwgTK59P9z4m5Qh for ; Wed, 5 Jul 2023 00:27:01 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QwgTK50nVz3psH; Wed, 5 Jul 2023 00:27:01 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688516821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+pfa75dkYPhaNuL0qBE4er0b+ItLRZKPG/u8ij1aht4=; b=avKxs/THkdQSZnLPhdH3XDqvwW+QaPlM8hRdazQf+D4nIRk97f86ef9xAMyJnjJEd9yNFp GIJ8HSsUzLPaPczsqEYmO0RtgPnKJoZcraKZqNQjxbkxHBxwa3qluHKwqV4abxZRH4+Ri4 73JIecazyI3cKZAgWqTFgh5AxShNB8MVjJcrYJIU1bgFMrx3Vb5Ox6/gHBs9TOAA5y5j4f w+O2ydGdXSeV6Ia/GK39upHa8vCW8HvpOuiCYhbSkHC22CelBPyBtlsDJdSjj1ffrma9PY bJlbWC8Jsvq2DmoBkK27JX+dp3tRC5+W2AiF81JKgRpPEiyQqaHYvOa8cLgO/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688516821; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+pfa75dkYPhaNuL0qBE4er0b+ItLRZKPG/u8ij1aht4=; b=yXbjpRbeGm5P2Hqbt4elDfYlD12xhT4q24VfO8oeaBzGBjmcdizZIKburk/ZEJ10C/XVbC QNzkgqFiC0G2rJz5SeCtG2OhYj/S6JSAOtKNRYPagYVXar3rSsvLGjicZn8onyR9DeI0st g7tk9fKqNlNB+oFEN3ifgxEfvKn++iVhIEo0FzUEmRNayASZgdRMgXA3pKYj+kCf67Z2Ts mmt5suSfDztwO8vBOGp0MtEVHuf9pJKuzcNKRvJ5qnZxLy3r9XnsXv9m1zLQKVlswWaRwa gBwYC+a4eloMfVaYh6Lam8tXmwEg+mhEcgdHm/6lAFqYuxRLbk63bBloVIFH7w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688516821; a=rsa-sha256; cv=none; b=mFPRKrBKGCTSyFZitiVB3nYhGk+e5cpMaa1nG3cELhBfzbVrV52Xez1LNcwKn8wEz4McF0 wPSfMrohhLwRGFpUxvfxUEvP4p2ExGMFVZ53JnWJHN4YIQTV5ZHJSvakWRJKwJoCN3LhX2 gM0xBYqtrVp52cRGaoYtRJjHTZoaY2zRL0cWoaNMTJzergNMB3SAs+Mv1+psknpD+1ERDt ePVWbMy/ga/kiPuKxpGMJQAAXduMcED09FL67fl/6nvSZPnyw9sIoipyrq7j+4M3Yv+DAr 6u9WTzDdwaEqIN1yNn4ipvHo0mdkMApuu2voJnfmjxKiNkXlapYGEZYKywww+w== Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QwgTK3v9zzSvV; Wed, 5 Jul 2023 00:27:01 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4035dd6b349so19731901cf.3; Tue, 04 Jul 2023 17:27:01 -0700 (PDT) X-Gm-Message-State: AC+VfDwuH2aUfoOfySVK10If5znZUjjuVcz5qdeHYJYb0aNZNfvfwPQJ 8blcLw9NOjKwqFtUS4imOcatik+0a2uWx1wWOUg= X-Google-Smtp-Source: ACHHUZ6YGw85C7Y6V2saInCkC+idHJDJJ6omylBJ7RAvGfeJxrlex8vbe5WXYY3gDNbDjRjtlCAdlsFAF4WW3SIhvZA= X-Received: by 2002:a05:622a:142:b0:3f1:f599:c259 with SMTP id v2-20020a05622a014200b003f1f599c259mr17394153qtw.24.1688516820565; Tue, 04 Jul 2023 17:27:00 -0700 (PDT) List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 References: <22F61A7B-3566-4761-8D7A-DC78B9CF20E6@FreeBSD.org> In-Reply-To: From: Nuno Teixeira Date: Wed, 5 Jul 2023 01:26:49 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: glib2 deprecated declarations failing on clang16 To: Charlie Li Cc: Dimitry Andric , Danilo Egea Gondolfo , FreeBSD Ports Content-Type: multipart/alternative; boundary="00000000000049858905ffb275c0" X-ThisMailContainsUnwantedMimeParts: N --00000000000049858905ffb275c0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello all, Ticket opened at upstream: https://sourceforge.net/p/bluefish/tickets/75/ https://cgit.freebsd.org/ports/commit/?id=3De95c4bea425b3e3c49b63e0cf4eff24= af40c574b Thank you! Charlie Li escreveu no dia ter=C3=A7a, 4/07/2023 =C3= =A0(s) 18:33: > Nuno Teixeira wrote: > > (...) > > > > Should this be applied upstream? > > I could open a upstream PR about it. > > > After looking through some history on the glib side (which have been > fixing incompatible function pointer conditions as they appear), > G_CALLBACK() should be applied to bluefish. Upstreaming is a good idea. > > Nuno Teixeira > > > escreveu no dia ter=C3=A7a, 4/07/2023 =C3=A0(s) 15:42: > > > > And run test sucess at main-n263935-e8423423737e > > > > I will do more testport builds with gtk2 and gtk3. > > > > I will use something like in commit msg: > > --- > > Fix build with clang16 > > Use G_CALLBACK() macro to silence incompatible function pointer > > warnings and > > disables any argument checks. > > > > Reported by: dim > > --- > > > > Cheers, > > > > Dimitry Andric > escreveu > > no dia ter=C3=A7a, 4/07/2023 =C3=A0(s) 15:31: > > > > I got to exactly the same patches. This is due to how glib's > > gclosure.h > > header declares its callback function type as '(void)', even > > though in > > reality the number and type of the arguments varies: > > > > /** > > * GCallback: > > * > > * The type used for callback functions in structure > > definitions and function > > * signatures. > > * > > * This doesn't mean that all callback functions must take > > no parameters and > > * return void. The required signature of a callback functio= n > > is determined by > > > > * the context in which is used (e.g. the signal to which > > it is connected). > > * > > * Use G_CALLBACK() to cast the callback function to a > > #GCallback. > > */ > > typedef void (*GCallback) (void); > > > > It would have been better if glib had just used '(...)', but th= e > > solution they have chosen requires each callback function to be > cast > > using the G_CALLBACK() macro. > > > > That basically shuts up any incompatible function pointer > > warnings, and > > disables any argument checks. > > > > -Dimitry > > > > > On 4 Jul 2023, at 16:21, Nuno Teixeira > > wrote: > > > > > > Hello Danilo! > > > > > > Yes, it builds ok. > > > > > > I will do a run test tomorrow on bluefish. > > > > > > Any hint on how to explain it in commit: > > > > > > --- > > > --- src/bftextview2_autocomp.c.orig 2023-07-04 14:09:37 > UTC > > > +++ src/bftextview2_autocomp.c > > > @@ -429,7 +429,7 @@ acwin_create(BluefishTextView * btv) > > > /*gtk_widget_set_size_request(acw->reflabel,150,-1); > */ > > > gtk_widget_show_all(acw->scroll); > > > gtk_widget_show(hbox); > > > - g_signal_connect(acw->reflabel, "activate-link", > > acw_label_active_link_lcb, acw); > > > + g_signal_connect(acw->reflabel, "activate-link", > > G_CALLBACK(acw_label_active_link_lcb), acw); > > > > > /*gtk_widget_set_size_request(GTK_WIDGET(acw->tree),100,200); > */ > > > /*gtk_widget_set_size_request(acw->win, 150, 200); *= / > > > > > > /*g_signal_connect(G_OBJECT(acw->win),"key-release-event",G_CALLBACK(acw= in_key_release_lcb),acw); > */ > > > --- > > > and > > > --- > > > --- src/external_commands.c.orig 2023-07-04 14:12:18 > UTC > > > +++ src/external_commands.c > > > @@ -483,7 +483,7 @@ create_commandstring(Texternalp * ep, > > const gchar * fo > > > > > > gtk_dialog_set_default_response(GTK_DIALOG(dialog),GTK_RESPONSE_ACCEPT); > > > tmp =3D g_strdup_printf(_("Supply arguments = to > > define %%a in '%s'"), formatstring); > > > entry =3D dialog_entry_labeled(NULL, tmp, > > gtk_dialog_get_content_area(GTK_DIALOG(dialog)), 6); > > > - g_signal_connect(G_OBJECT(entry), "activate"= , > > command_dialog_entry_activated_lcb, dialog); > > > + g_signal_connect(G_OBJECT(entry), "activate"= , > > G_CALLBACK(command_dialog_entry_activated_lcb), dialog); > > > g_free(tmp); > > > gtk_widget_show_all(dialog); > > > result =3D gtk_dialog_run(GTK_DIALOG(dialog)= ); > > > --- > > > > > > Thanks! > > > > > > Danilo Egea Gondolfo > > escreveu no dia ter=C3=A7a, 4/07/2= 023 > > =C3=A0(s) 15:00: > > > On 04/07/2023 14:56, Dimitry Andric wrote: > > > > > > > On 4 Jul 2023, at 14:37, Nuno Teixeira > > wrote: > > > >> I'm getting build errors from current with www/bluefish > > about deprecated glib2 declarations and causing build to fail > > with clang16: > > > >> --- > > > >> /usr/local/include/glib-2.0/glib/gmacros.h:1262:37: note: > > expanded from macro 'G_DEPRECATED' > > > >> #define G_DEPRECATED __attribute__((__deprecated__)) > > > >> ^ > > > >> mv -f .deps/bluefish.Tpo .deps/bluefish.Po > > > >> bftextview2_langmgr.c:2665:2: warning: > > 'g_thread_create_full' is deprecated: Use 'g_thread_new' instea= d > > [-Wdeprecated-declarations] > > > >> g_thread_create_full(build_bflang2scan_thread, > > NULL, 0, FALSE, FALSE, G_THREAD_PRIORITY_LOW, &gerror); > > > >> --- > > > >> > > > >> Any help is welcome on finding out its cause. > > > >> > > > >> a related issue: > > https://github.com/PCSX2/pcsx2/issues/3315 > > > > > >> > > > >> Build log: > > > https://pkg-status.freebsd.org/beefy17/data/main-i386-default/pf46bd2c584= 25_s0631830a7a/logs/bluefish-2.2.14.log > < > https://pkg-status.freebsd.org/beefy17/data/main-i386-default/pf46bd2c584= 25_s0631830a7a/logs/bluefish-2.2.14.log > > > > > > The actual error is an incompatible callback function > > signature: > > > > > > > > bftextview2_autocomp.c:432:2: error: incompatible function > > pointer types passing 'gboolean (GtkLabel *, gchar *, gpointer)= ' > > (aka 'int (struct _GtkLabel *, char *, void *)') to parameter o= f > > type 'GCallback' (aka 'void (*)(void)') > > [-Wincompatible-function-pointer-types] > > > > g_signal_connect(acw->reflabel, "activate-link", > > acw_label_active_link_lcb, acw); > > > > > > > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~ > > > > /usr/local/include/glib-2.0/gobject/gsignal.h:515:59: note= : > > expanded from macro 'g_signal_connect' > > > > g_signal_connect_data ((instance), (detailed_signal), > > (c_handler), (data), NULL, (GConnectFlags) 0) > > > > ^~~~~~~~~~~ > > > > /usr/local/include/glib-2.0/gobject/gsignal.h:411:25: note= : > > passing argument to parameter 'c_handler' here > > > > GCallback c_handler, > > > > ^ > > > > > > > > I have seen these more often with glib-based applications. > > In some cases > > > > it is feasible to fix the callback function to have the > correct > > > > signature, in other cases you can slap a cast in place. Or= , > > if the > > > > affected code is vala-generated (also happens), the big > > hammer is to > > > > suppress the warning(s). > > > > > > > > -Dimitry > > > > > > > Not a glib expert here, but you can try this > > https://pastebin.com/ty8hLjVU > > > > > > > > > > > > -- > > > Nuno Teixeira > > > FreeBSD Committer (ports) > > > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > > > > > > > -- > > Nuno Teixeira > > FreeBSD Committer (ports) > > -- > Charlie Li > =E2=80=A6nope, still don't have an exit line. > > --=20 Nuno Teixeira FreeBSD Committer (ports) --00000000000049858905ffb275c0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello all,



Thank you!

Charlie Li <vishwin@freebsd.org<= /a>> escreveu no dia ter=C3=A7a, 4/07/2023 =C3=A0(s) 18:33:
Nuno Teixeira wrote:
> (...)
>
> Should this be applied upstream?
> I could open a upstream PR about it.
>
After looking through some history on the glib side (which have been
fixing incompatible function pointer conditions as they appear),
G_CALLBACK() should be applied to bluefish. Upstreaming is a good idea.
> Nuno Teixeira <eduardo@freebsd.org <mailto:eduardo@freebsd.org>>
> escreveu no dia ter=C3=A7a, 4/07/2023 =C3=A0(s) 15:42:
>
>=C2=A0 =C2=A0 =C2=A0And run test sucess at main-n263935-e8423423737e >
>=C2=A0 =C2=A0 =C2=A0I will do more testport builds with gtk2 and gtk3.<= br> >
>=C2=A0 =C2=A0 =C2=A0I will use something like in commit msg:
>=C2=A0 =C2=A0 =C2=A0---
>=C2=A0 =C2=A0 =C2=A0Fix build with clang16
>=C2=A0 =C2=A0 =C2=A0Use G_CALLBACK() macro to silence incompatible func= tion pointer
>=C2=A0 =C2=A0 =C2=A0warnings and
>=C2=A0 =C2=A0 =C2=A0disables any argument checks.
>
>=C2=A0 =C2=A0 =C2=A0Reported by: dim
>=C2=A0 =C2=A0 =C2=A0---
>
>=C2=A0 =C2=A0 =C2=A0Cheers,
>
>=C2=A0 =C2=A0 =C2=A0Dimitry Andric <dim@freebsd.org <mailto:dim@freebsd.org>> escreveu
>=C2=A0 =C2=A0 =C2=A0no dia ter=C3=A7a, 4/07/2023 =C3=A0(s) 15:31:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0I got to exactly the same patches. Th= is is due to how glib's
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gclosure.h
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0header declares its callback function= type as '(void)', even
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0though in
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reality the number and type of the ar= guments varies:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 /**
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* GCallback:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* The type used for cal= lback functions in structure
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0definitions and function
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* signatures.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* This doesn't mean= that all callback functions must take
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0no=C2=A0 parameters and
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* return void. The requ= ired signature of a callback function
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0is determined by=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 * the context i= n which is used (e.g. the signal to which
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0it is connected).
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0* Use G_CALLBACK() to c= ast the callback function to a
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#GCallback.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0*/
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 typedef void=C2=A0 (*GCallbac= k)=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (void);
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0It would have been better if glib had= just used '(...)', but the
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0solution they have chosen requires ea= ch callback function to be cast
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0using the G_CALLBACK() macro.
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0That basically shuts up any incompati= ble function pointer
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0warnings, and
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0disables any argument checks.
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0-Dimitry
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > On 4 Jul 2023, at 16:21, Nuno T= eixeira <eduard= o@freebsd.org
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<mailto:eduardo@freebsd.org>> wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Hello Danilo!
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Yes, it builds ok.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > I will do a run test tomorrow o= n bluefish.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Any hint on how to explain it i= n commit:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > ---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > --- src/bftextview2_autocomp.c.= orig=C2=A0 =C2=A0 =C2=A02023-07-04 14:09:37 UTC
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > +++ src/bftextview2_autocomp.c<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > @@ -429,7 +429,7 @@ acwin_creat= e(BluefishTextView * btv)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0/*gtk_widget_set_size_request(acw->reflabel,150,-1); */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0gtk_widget_show_all(acw->scroll);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0gtk_widget_show(hbox);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > -=C2=A0 =C2=A0 =C2=A0 =C2=A0g_s= ignal_connect(acw->reflabel, "activate-link",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0acw_label_active_link_lcb, acw);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > +=C2=A0 =C2=A0 =C2=A0 =C2=A0g_s= ignal_connect(acw->reflabel, "activate-link",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0G_CALLBACK(acw_label_active_link_lcb)= , acw);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/*gtk_widget_set_size_request(= GTK_WIDGET(acw->tree),100,200); */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0/*gtk_widget_set_size_request(acw->win, 150, 200); */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/*g_signal_connect(G_OBJECT(ac= w->win),"key-release-event",G_CALLBACK(acwin_key_release_lcb),= acw); */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > ---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > and
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > ---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > --- src/external_commands.c.ori= g=C2=A0 =C2=A0 =C2=A0 =C2=A0 2023-07-04 14:12:18 UTC
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > +++ src/external_commands.c
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > @@ -483,7 +483,7 @@ create_comm= andstring(Texternalp * ep,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0const gchar * fo
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gtk_dialog_set_default_respons= e(GTK_DIALOG(dialog),GTK_RESPONSE_ACCEPT);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0tmp =3D g_strdup_printf(_("Supply argum= ents to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0define %%a in '%s'"), fo= rmatstring);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0entry =3D dialog_entry_labeled(NULL, tmp, >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gtk_dialog_get_content_area(GTK_DIALO= G(dialog)), 6);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0g_signal_connect(G_OBJECT(entry), "activate= ",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0command_dialog_entry_activated_lcb, d= ialog);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0g_signal_connect(G_OBJECT(entry), "activate= ",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0G_CALLBACK(command_dialog_entry_activ= ated_lcb), dialog);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0g_free(tmp);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gtk_widget_show_all(dialog);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0result =3D gtk_dialog_run(GTK_DIALOG(dialog)= );
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > ---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Thanks!
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Danilo Egea Gondolfo <danilo@freebsd.org >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<mailto:danilo@freebsd.org>> escreveu no di= a ter=C3=A7a, 4/07/2023
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=C3=A0(s) 15:00:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > On 04/07/2023 14:56, Dimitry An= dric wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > On 4 Jul 2023, at 14:37, N= uno Teixeira <e= duardo@freebsd.org
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<mailto:eduardo@freebsd.org>> wrote:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> I'm getting build = errors from current with www/bluefish
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0about deprecated glib2 declarations a= nd causing build to fail
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0with clang16:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> ---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> /usr/local/include/gli= b-2.0/glib/gmacros.h:1262:37: note:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0expanded from macro 'G_DEPRECATED= '
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> #define G_DEPRECATED _= _attribute__((__deprecated__))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >>=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> mv -f .deps/bluefish.T= po .deps/bluefish.Po
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> bftextview2_langmgr.c:= 2665:2: warning:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'g_thread_create_full' is dep= recated: Use 'g_thread_new' instead
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0[-Wdeprecated-declarations]
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >>=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 g_thread_create_full(build_bflang2scan_thread,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0NULL, 0, FALSE, FALSE, G_THREAD_PRIOR= ITY_LOW, &gerror);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> ---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> Any help is welcome on= finding out its cause.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> a related issue:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://github.com/P= CSX2/pcsx2/issues/3315
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<https://github.c= om/PCSX2/pcsx2/issues/3315>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >> Build log:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://pkg-status.freebs= d.org/beefy17/data/main-i386-default/pf46bd2c58425_s0631830a7a/logs/bluefis= h-2.2.14.log <https://pkg-status.freebsd.org/beefy17/da= ta/main-i386-default/pf46bd2c58425_s0631830a7a/logs/bluefish-2.2.14.log= >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > The actual error is an inc= ompatible callback function
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0signature:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > bftextview2_autocomp.c:432= :2: error: incompatible function
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pointer types passing 'gboolean (= GtkLabel *, gchar *, gpointer)'
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(aka 'int (struct _GtkLabel *, ch= ar *, void *)') to parameter of
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0type 'GCallback' (aka 'vo= id (*)(void)')
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0[-Wincompatible-function-pointer-type= s]
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > g_signal_connect(acw->r= eflabel, "activate-link",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0acw_label_active_link_lcb, acw);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > /usr/local/include/glib-2.= 0/gobject/gsignal.h:515:59: note:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0expanded from macro 'g_signal_con= nect'
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > g_signal_connect_data ((in= stance), (detailed_signal),
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(c_handler), (data), NULL, (GConnectF= lags) 0)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > ^~~~~~~~~~~
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > /usr/local/include/glib-2.= 0/gobject/gsignal.h:411:25: note:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0passing argument to parameter 'c_= handler' here
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > GCallback c_handler,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > ^
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > I have seen these more oft= en with glib-based applications.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0In some cases
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > it is feasible to fix the = callback function to have the correct
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > signature, in other cases = you can slap a cast in place. Or,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if the
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > affected code is vala-gene= rated (also happens), the big
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0hammer is to
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > suppress the warning(s). >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > > -Dimitry
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Not a glib expert here, but you= can try this
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0https://pastebin.com/ty8hLjVU= <https://pastebin.com/ty8hLjVU>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 >
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > --
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > Nuno Teixeira
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 > FreeBSD Committer (ports)
>
>
>
>=C2=A0 =C2=A0 =C2=A0--
>=C2=A0 =C2=A0 =C2=A0Nuno Teixeira
>=C2=A0 =C2=A0 =C2=A0FreeBSD Committer (ports)
>
>
>
> --
> Nuno Teixeira
> FreeBSD Committer (ports)

--
Charlie Li
=E2=80=A6nope, still don't have an exit line.



--
Nuno Teixeira
FreeBSD Committ= er (ports)
--00000000000049858905ffb275c0--