From nobody Sat Feb 11 12:01:26 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PDTjB3vY6z3q2jP for ; Sat, 11 Feb 2023 12:01:34 +0000 (UTC) (envelope-from fbl@aoek.com) Received: from mail.yourbox.net (mail.yourbox.net [IPv6:2001:41d0:1:767d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.yourbox.net", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PDTjB1Jv7z3Hd0; Sat, 11 Feb 2023 12:01:34 +0000 (UTC) (envelope-from fbl@aoek.com) Authentication-Results: mx1.freebsd.org; none Received: from mail.yourbox.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail.yourbox.net (8.17.1/8.17.1) with ESMTP id 31BC1V2L018215; Sat, 11 Feb 2023 13:01:31 +0100 (CET) (envelope-from fbl@aoek.com) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=aoek.com; s=mailbox; t=1676116891; bh=m8Ye7uE0M+P41olOu8S/tUW/Dfbmz9GU7s3VZxrz/dY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=btyuRaQgNqak9eA9l6jhBZcpydLhdXJ2THQMawJDdHKsjD0oYRthaMlucB0zC4WcZ r02s30NVHAYp+kF7mlrAN/blMYccsFWTgVE+4sYOTgCl7YX074YLdJ19Qy2OrzdvbI SHeBsdAGc3mvNpuV0V45E27NQjms/4UjQdz9Z+IF/oPV5cZD0P5sqUMhO1RpaXuqMC FmoTVnPusatj5KCe5oYQ/MfmjLBXVbmFMVcPwGnpaLxSDPCBO3QeP0Lq+DDbwmiOt8 4NOmCNQq7yEZ5fP56YqLmbgEtz0h3SX00MSVsR+6ncMxJQGGENeN4mxy4MGX6iuxih g6YPkpwwRPMuw== List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Sat, 11 Feb 2023 13:01:26 +0100 From: =?UTF-8?Q?Jos=C3=A9_P=C3=A9rez?= To: FreeBSD Ports Cc: andrew clarke , Guido Falsi Subject: Re: editors/uemacs fails to biuld on 14.0-CURRENT 1400079 In-Reply-To: References: <8aceaed7bb0323fc53143a8befd35170@mail.yourbox.net> <20230211111245.o3qjm3oyncivtipu@ozzmosis.com> Message-ID: X-Sender: fbl@aoek.com User-Agent: Roundcube Webmail/1.2.0 X-Rspamd-Queue-Id: 4PDTjB1Jv7z3Hd0 X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16276, ipnet:2001:41d0::/32, country:FR] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N El 2023-02-11 12:45, Guido Falsi escribió: > On 11/02/23 12:12, andrew clarke wrote: >> Hi José, >> >> On 2023-02-11 08:16:16, José Pérez (fbl@aoek.com) wrote: >> >>> Hi, >>> I get the following error when poudriere building editors/uemacs on ... >> The MicroEMACS source code was all written in vintage K&R style. >> Evidently >> newer versions of Clang increasingly have a problem with this, which I >> guess is unsurprising since the minimum C standard Clang is designed >> for is >> probably C89/C90. >> ... > Something like -Wno-error=int-conversion or -Wno-int-conversion should > make the error go away. Same with similar issues with this code. This patch compiles, as a workaround proposed by Guido: diff --git a/editors/uemacs/Makefile b/editors/uemacs/Makefile index f999cc978685..48111ffb8824 100644 --- a/editors/uemacs/Makefile +++ b/editors/uemacs/Makefile @@ -19,6 +19,8 @@ NO_WRKSUBDIR= yes USES= dos2unix ncurses zip EXTRACT_BEFORE_ARGS= -Lq +CFLAGS+= -Wno-int-conversion + post-patch: @${REINPLACE_CMD} -e "s|%%PREFIX%%|${PREFIX}|g" ${WRKSRC}/src/*.c @${REINPLACE_CMD} -e 's|-ltermcap|${LDFLAGS} -lncurses|g' \ > I'm not advocating doing this in general. In fact patching the code to > not cause these errors should be the solution, but for old code that > is not going to change upstream, maybe disabling the warnings is the > correct fix. Agreed. For the time being I am using the workaround, will see whether a consistent patch can be upstreamed. Regards, -- José Pérez