From nobody Fri Dec 15 10:52:33 2023 X-Original-To: freebsd-ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Ss5f06wPJz52dsm for ; Fri, 15 Dec 2023 10:52:40 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Received: from mailer.gwdg.de (mailer.gwdg.de [134.76.10.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Ss5dz5D8tz3T3G; Fri, 15 Dec 2023 10:52:39 +0000 (UTC) (envelope-from rhurlin@gwdg.de) Authentication-Results: mx1.freebsd.org; dkim=none; spf=pass (mx1.freebsd.org: domain of rhurlin@gwdg.de designates 134.76.10.26 as permitted sender) smtp.mailfrom=rhurlin@gwdg.de; dmarc=none Received: from mbx19-gwd-03.um.gwdg.de ([10.108.142.56] helo=email.gwdg.de) by mailer.gwdg.de with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (GWDG Mailer) (envelope-from ) id 1rE5o1-0005xC-3B; Fri, 15 Dec 2023 11:52:34 +0100 Received: from [192.168.178.23] (10.250.9.199) by MBX19-GWD-03.um.gwdg.de (10.108.142.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.2.1258.28; Fri, 15 Dec 2023 11:52:33 +0100 Content-Type: multipart/mixed; boundary="------------tRu3hInHUNGCZzSO0Vp0oLQS" Message-ID: <58389025-d360-4d62-af97-09c66699d42a@gwdg.de> Date: Fri, 15 Dec 2023 11:52:33 +0100 List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: devel/electron25: Build failure on CURRENT with clang17 Content-Language: en-US From: Rainer Hurling To: Dimitry Andric CC: , FreeBSD Mailing List Reply-To: Rainer Hurling References: <3A903343-1A21-474D-82A2-ACE40DCE19D3@FreeBSD.org> <39cb099e-73cb-4532-8b2d-a10be1487a12@gwdg.de> In-Reply-To: <39cb099e-73cb-4532-8b2d-a10be1487a12@gwdg.de> X-Originating-IP: [10.250.9.199] X-ClientProxiedBy: EXCMBX-02.um.gwdg.de (134.76.9.217) To MBX19-GWD-03.um.gwdg.de (10.108.142.56) X-Spam-Level: - X-Virus-Scanned: (clean) by clamav X-Spamd-Result: default: False [-1.19 / 15.00]; MIME_BAD_ATTACHMENT(1.60)[h:text/x-chdr]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_BASE64_TEXT_BOGUS(1.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RWL_MAILSPIKE_EXCELLENT(-0.40)[134.76.10.26:from]; RCVD_IN_DNSWL_MED(-0.20)[134.76.10.26:from]; R_SPF_ALLOW(-0.20)[+ip4:134.76.10.0/23]; MIME_BASE64_TEXT(0.10)[]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-chdr]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; HAS_REPLYTO(0.00)[rhurlin@FreeBSD.org]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; FREEFALL_USER(0.00)[rhurlin]; DMARC_NA(0.00)[gwdg.de]; ARC_NA(0.00)[]; ASN(0.00)[asn:207592, ipnet:134.76.0.0/16, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; REPLYTO_DN_EQ_FROM_DN(0.00)[]; TO_DN_SOME(0.00)[]; HAS_XOIP(0.00)[]; RCVD_TLS_LAST(0.00)[]; HAS_ATTACHMENT(0.00)[]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[freebsd-ports@freebsd.org]; MIME_TRACE(0.00)[0:+,1:+,2:+]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4Ss5dz5D8tz3T3G X-Spamd-Bar: - --------------tRu3hInHUNGCZzSO0Vp0oLQS Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Am 15.12.23 um 06:39 schrieb Rainer Hurling: > Am 15.12.23 um 00:53 schrieb Dimitry Andric: >> On 14 Dec 2023, at 21:23, Dimitry Andric wrote: >>> >>> On 14 Dec 2023, at 20:49, Rainer Hurling wrote: >>>> >>>> On my FreeBSD 15.0-CURRENT amd64 boxes with clang 17 as base >>>> compiler I get: >>>> >>>> ===>  Building for electron25-25.9.8_1 >>>> ninja: Entering directory `out/Release' >>>> [  0% 1/32805] c++ -MMD -MF obj/base/base/reentry_guard.o.d >>>> -DBASE_IMPLEMENTATION -DIS_RAW_PTR_IMPL -DSYSTEM_NATIVE_UTF8 >>>> -DUSE_SYMBOLIZE -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_OZONE=1 >>>> -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS >>>> -D_FORTIFY_SOURCE=2  -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE >>>> -D_LARGEFILE64_SOURCE >> -DNO_UNWIND_TABLES -D_GNU_SOURCE -DNDEBUG -DNVALGRIND >> -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DIS_MAS_BUILD\(\)=0 >> -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56 >> -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56 -DUSE_SYSTEM_LIBEVENT=1 >> -DGLOG_EXPORT= -DUSING_SYSTEM_ICU=1 >>>> -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DU_FINAL=final >>>> -DU_NOEXCEPT=noexcept -DU_OVERRIDE=override -DU_IMPORT=U_EXPORT >>>> -I../.. -Igen -I../../third_party/perfetto/include >>>> -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto >>>> -Igen/shim_headers/libevent_shim  -Igen/shim_headers/icui18n_shim >>>> -Igen/shim_headers/icuuc_shim >> -I../../third_party/abseil-cpp >> -I../../third_party/boringssl/src/include >> -I../../third_party/protobuf/src -Igen/protoc_out -Wall -Wextra >> -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive >> -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter >> -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration >> -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wshadow >> -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing >> --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables >> -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics >> -fmerge-all-constants -m64 -msse3 -Xclang -fdebug-compilation-dir >> -Xclang . -no-canonical-prefixes -ftrivial-auto-var-init=pattern >> -fno-omit-frame-pointer -g0 -fvisibility=hidden -Wheader-hygiene >> -Wstring-conversion -Wtautological-overlap-compare -Wshorten-64-to-32 >> -Wimplicit-int-conversion -Wsign-compare -Wsign-conversion >> -Wtautological-unsigned-zero-compare -Wexit-time-destructors >> -Wglobal-constructors -I/usr/local/include >> -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -O2 >> -fdata-sections -ffunction-sections -fno-unique-section-names >> -DPROTOBUF_ALLOW_DEPRECATED=1 -I/usr/local/include >> -I/usr/local/include -std=c++20 -Wno-trigraphs -fno-exceptions >> -fno-rtti -fvisibility-inlines-hidden -O2 -pipe >> -fstack-protector-strong -isystem /usr/local/include >> -fno-strict-aliasing  -isystem /usr/local/include  -c >> ../../base/allocator/dispatcher/reentry_guard.cc -o >> obj/base/base/reentry_guard.o >>>> FAILED: obj/base/base/reentry_guard.o >>>> c++ -MMD -MF obj/base/base/reentry_guard.o.d -DBASE_IMPLEMENTATION >>>> -DIS_RAW_PTR_IMPL -DSYSTEM_NATIVE_UTF8 -DUSE_SYMBOLIZE -DUSE_AURA=1 >>>> -DUSE_GLIB=1 -DUSE_OZONE=1 -DOFFICIAL_BUILD -D__STDC_CONSTANT_MACROS >>>> -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_FILE_OFFSET_BITS=64 >>>> -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES >> -D_GNU_SOURCE -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 >> -DIS_MAS_BUILD\(\)=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_56 >> -DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_56 -DUSE_SYSTEM_LIBEVENT=1 >> -DGLOG_EXPORT= -DUSING_SYSTEM_ICU=1 >> -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DU_FINAL=final >> -DU_NOEXCEPT=noexcept -DU_OVERRIDE=override -DU_IMPORT=U_EXPORT >> -I../.. -Igen -I../../third_party/perfetto/include >> -Igen/third_party/perfetto/build_config -Igen/third_party/perfetto >> -Igen/shim_headers/libevent_shim -Igen/shim_headers/icui18n_shim >> -Igen/shim_headers/icuuc_shim -I../../third_party/abseil-cpp >> -I../../third_party/boringssl/src/include >> -I../../third_party/protobuf/src -Igen/protoc_out -Wall -Wextra >> -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive >> -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter >> -Wno-psabi -Wloop-analysis -Wno-unneeded-internal-declaration >> -Wenum-compare-conditional -Wno-ignored-pragma-optimize -Wshadow >> -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing >> --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables >> -fno-asynchronous-unwind-tables -fPIC -pthread -fcolor-diagnostics >> -fmerge-all-constants -m64 -msse3 -Xclang -fdebug-compilation-dir >> -Xclang . -no-canonical-prefixes -ftrivial-auto-var-init=pattern >> -fno-omit-frame-pointer -g0 -fvisibility=hidden -Wheader-hygiene >> -Wstring-conversion -Wtautological-overlap-compare -Wshorten-64-to-32 >> -Wimplicit-int-conversion -Wsign-compare -Wsign-conversion >> -Wtautological-unsigned-zero-compare -Wexit-time-destructors >> -Wglobal-constructors -I/usr/local/include >> -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -O2 >> -fdata-sections -ffunction-sections -fno-unique-section-names >> -DPROTOBUF_ALLOW_DEPRECATED=1 -I/usr/local/include >> -I/usr/local/include -std=c++20 -Wno-trigraphs -fno-exceptions >> -fno-rtti -fvisibility-inlines-hidden -O2 -pipe >> -fstack-protector-strong -isystem /usr/local/include >> -fno-strict-aliasing  -isystem /usr/local/include  -c >> ../../base/allocator/dispatcher/reentry_guard.cc -o >> obj/base/base/reentry_guard.o >>>> In file included from >>>> ../../base/allocator/dispatcher/reentry_guard.cc:9: >>>> In file included from ../../base/debug/crash_logging.h:16: >>>> In file included from >>>> ../../base/strings/string_number_conversions.h:15: >>>> In file included from ../../base/containers/span.h:19: >>>> ../../base/containers/checked_iterators.h:248:8: error: no template >>>> named '__is_cpp17_contiguous_iterator'; did you mean >>>> '__libcpp_is_contiguous_iterator'? >>>> 248 | struct >>>> __is_cpp17_contiguous_iterator<::base::CheckedContiguousIterator> >>>>      |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>>>      |        __libcpp_is_contiguous_iterator >>>> /usr/include/c++/v1/__iterator/iterator_traits.h:476:8: note: >>>> '__libcpp_is_contiguous_iterator' declared here >>>> 476 | struct __libcpp_is_contiguous_iterator : _Or< >>>>      |        ^ >>>> 1 error generated. >>>> ninja: build stopped: subcommand failed. >>>> *** Error code 1 >>> >>> This is the same problem that I fixed for qt6-webengine here: >>> https://cgit.freebsd.org/ports/commit/?id=660b01aa59ee1266ce0faf5718dc5c90abfa4f31 >>> >>> I'll take a look. >> >> I haven't yet been able to build the port itself as my test machine is >> swamped with jobs, but the patch from qt6-webengine applied without >> fuzz. Can you please try the attached diff? >> >> -Dimitry > > It applies fine here, I am building now and will report back. > > Many thanks so far! The build and installation are ok, the updated electron25 seems usable, tested by updating editors/vscode :D Attached you will find the almost same patch, but in the naming convention of ports, derived by 'make makepatch'. BTW, do we also have to patch other electon versions? Again, many thanks for your quick help. Best wishes, Rainer --------------tRu3hInHUNGCZzSO0Vp0oLQS Content-Type: text/x-chdr; charset="UTF-8"; name="patch-base_containers_checked__iterators.h" Content-Disposition: attachment; filename="patch-base_containers_checked__iterators.h" Content-Transfer-Encoding: base64 LS0tIGJhc2UvY29udGFpbmVycy9jaGVja2VkX2l0ZXJhdG9ycy5oLm9yaWcJMjAyMy0wOC0x MiAwNzowNzoxMCBVVEMKKysrIGJhc2UvY29udGFpbmVycy9jaGVja2VkX2l0ZXJhdG9ycy5o CkBAIC0yNCw2ICsyNCw5IEBAIGNsYXNzIENoZWNrZWRDb250aWd1b3VzSXRlcmF0b3Igewog ICB1c2luZyBwb2ludGVyID0gVCo7CiAgIHVzaW5nIHJlZmVyZW5jZSA9IFQmOwogICB1c2lu ZyBpdGVyYXRvcl9jYXRlZ29yeSA9IHN0ZDo6cmFuZG9tX2FjY2Vzc19pdGVyYXRvcl90YWc7 CisjaWYgX19jcGx1c3BsdXMgPj0gMjAyMDAyTAorICB1c2luZyBpdGVyYXRvcl9jb25jZXB0 ID0gc3RkOjpjb250aWd1b3VzX2l0ZXJhdG9yX3RhZzsKKyNlbmRpZgogCiAgIC8vIFJlcXVp cmVkIGZvciBjb252ZXJ0aW5nIGNvbnN0cnVjdG9yIGJlbG93LgogICB0ZW1wbGF0ZSA8dHlw ZW5hbWUgVT4KQEAgLTMxLDEwICszNCw4IEBAIGNsYXNzIENoZWNrZWRDb250aWd1b3VzSXRl cmF0b3IgewogCiAgIC8vIFJlcXVpcmVkIGZvciBjZXJ0YWluIGxpYmMrKyBhbGdvcml0aG0g b3B0aW1pemF0aW9ucyB0aGF0IGFyZSBub3QgYXZhaWxhYmxlCiAgIC8vIGZvciBOYUNsLgot I2lmIGRlZmluZWQoX0xJQkNQUF9WRVJTSU9OKSAmJiAhQlVJTERGTEFHKElTX05BQ0wpCiAg IHRlbXBsYXRlIDx0eXBlbmFtZSBQdHI+CiAgIGZyaWVuZCBzdHJ1Y3Qgc3RkOjpwb2ludGVy X3RyYWl0czsKLSNlbmRpZgogCiAgIGNvbnN0ZXhwciBDaGVja2VkQ29udGlndW91c0l0ZXJh dG9yKCkgPSBkZWZhdWx0OwogCkBAIC0yMjQsNyArMjI1LDYgQEAgdXNpbmcgQ2hlY2tlZENv bnRpZ3VvdXNDb25zdEl0ZXJhdG9yID0gQ2hlY2tlZENvbnRpZ3VvCiAKIH0gIC8vIG5hbWVz cGFjZSBiYXNlCiAKLSNpZiBkZWZpbmVkKF9MSUJDUFBfVkVSU0lPTikgJiYgIUJVSUxERkxB RyhJU19OQUNMKQogLy8gU3BlY2lhbGl6ZSBib3RoIHN0ZDo6X19pc19jcHAxN19jb250aWd1 b3VzX2l0ZXJhdG9yIGFuZCBzdGQ6OnBvaW50ZXJfdHJhaXRzCiAvLyBmb3IgQ0NJIGluIGNh c2Ugd2UgY29tcGlsZSB3aXRoIGxpYmMrKyBvdXRzaWRlIG9mIE5hQ2wuIFRoZSBmb3JtZXIg aXMKIC8vIHJlcXVpcmVkIHRvIGVuYWJsZSBjZXJ0YWluIGFsZ29yaXRobSBvcHRpbWl6YXRp b25zIChlLmcuIHN0ZDo6Y29weSBjYW4gYmUgYQpAQCAtMjQyLDEzICsyNDIsMzUgQEAgdXNp bmcgQ2hlY2tlZENvbnRpZ3VvdXNDb25zdEl0ZXJhdG9yID0gQ2hlY2tlZENvbnRpZ3VvCiAv LyBbMV0gaHR0cHM6Ly93ZzIxLmxpbmsvaXRlcmF0b3IuY29uY2VwdC5jb250aWd1b3VzCiAv LyBbMl0gaHR0cHM6Ly93ZzIxLmxpbmsvc3RkLml0ZXJhdG9yLnRhZ3MKIC8vIFszXSBodHRw czovL3dnMjEubGluay9wb2ludGVyLnRyYWl0cy5vcHRtZW0KLW5hbWVzcGFjZSBzdGQgewog CisjaWYgZGVmaW5lZChfTElCQ1BQX1ZFUlNJT04pCisKKy8vIFRPRE8oY3JidWcuY29tLzEy ODQyNzUpOiBSZW1vdmUgd2hlbiBDKysyMCBpcyBvbiBieSBkZWZhdWx0LCBhcyB0aGUgdXNl CisvLyBvZiBgaXRlcmF0b3JfY29uY2VwdGAgYWJvdmUgc2hvdWxkIHN1ZmZpY2UuCitfTElC Q1BQX0JFR0lOX05BTUVTUEFDRV9TVEQKKworLy8gVE9ETyhjcmJ1Zy5jb20vMTQ0OTI5OSk6 IGh0dHBzOi8vcmV2aWV3cy5sbHZtLm9yZy9EMTUwODAxIHJlbmFtZWQgdGhpcyBmcm9tCisv LyBgX19pc19jcHAxN19jb250aWd1b3VzX2l0ZXJhdG9yYCB0byBgX19saWJjcHBfaXNfY29u dGlndW91c19pdGVyYXRvcmAuIENsZWFuCisvLyB1cCB0aGUgb2xkIHNwZWxsaW5nIGFmdGVy IGxpYmMrKyByb2xscy4KIHRlbXBsYXRlIDx0eXBlbmFtZSBUPgorc3RydWN0IF9faXNfY3Bw MTdfY29udGlndW91c19pdGVyYXRvcjsKK3RlbXBsYXRlIDx0eXBlbmFtZSBUPgogc3RydWN0 IF9faXNfY3BwMTdfY29udGlndW91c19pdGVyYXRvcjw6OmJhc2U6OkNoZWNrZWRDb250aWd1 b3VzSXRlcmF0b3I8VD4+CiAgICAgOiB0cnVlX3R5cGUge307CiAKIHRlbXBsYXRlIDx0eXBl bmFtZSBUPgorc3RydWN0IF9fbGliY3BwX2lzX2NvbnRpZ3VvdXNfaXRlcmF0b3I7Cit0ZW1w bGF0ZSA8dHlwZW5hbWUgVD4KK3N0cnVjdCBfX2xpYmNwcF9pc19jb250aWd1b3VzX2l0ZXJh dG9yPDo6YmFzZTo6Q2hlY2tlZENvbnRpZ3VvdXNJdGVyYXRvcjxUPj4KKyAgICA6IHRydWVf dHlwZSB7fTsKKworX0xJQkNQUF9FTkRfTkFNRVNQQUNFX1NURAorCisjZW5kaWYKKworbmFt ZXNwYWNlIHN0ZCB7CisKK3RlbXBsYXRlIDx0eXBlbmFtZSBUPgogc3RydWN0IHBvaW50ZXJf dHJhaXRzPDo6YmFzZTo6Q2hlY2tlZENvbnRpZ3VvdXNJdGVyYXRvcjxUPj4gewogICB1c2lu ZyBwb2ludGVyID0gOjpiYXNlOjpDaGVja2VkQ29udGlndW91c0l0ZXJhdG9yPFQ+OwogICB1 c2luZyBlbGVtZW50X3R5cGUgPSBUOwpAQCAtMjY3LDYgKzI4OSw1IEBAIHN0cnVjdCBwb2lu dGVyX3RyYWl0czw6OmJhc2U6OkNoZWNrZWRDb250aWd1b3VzSXRlcmF0bwogfTsKIAogfSAg Ly8gbmFtZXNwYWNlIHN0ZAotI2VuZGlmCiAKICNlbmRpZiAgLy8gQkFTRV9DT05UQUlORVJT X0NIRUNLRURfSVRFUkFUT1JTX0hfCg== --------------tRu3hInHUNGCZzSO0Vp0oLQS--