From nobody Fri Aug 18 06:43:11 2023 X-Original-To: ports@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RRslM4cTQz4qmsW for ; Fri, 18 Aug 2023 06:43:27 +0000 (UTC) (envelope-from tatsuki_makino@hotmail.com) Received: from APC01-PSA-obe.outbound.protection.outlook.com (mail-psaapc01olkn2099.outbound.protection.outlook.com [40.92.52.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RRslL0Mtvz4Yy2 for ; Fri, 18 Aug 2023 06:43:26 +0000 (UTC) (envelope-from tatsuki_makino@hotmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hotmail.com header.s=selector1 header.b=hk5AQYGz; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=fail (mx1.freebsd.org: domain of tatsuki_makino@hotmail.com does not designate 40.92.52.99 as permitted sender) smtp.mailfrom=tatsuki_makino@hotmail.com; dmarc=pass (policy=none) header.from=hotmail.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c2VuHHFyHsk4Z1np2OdNKNZPkWG0vpAU3uIkkxY2QkosX45EAAFSvZETVi0IgadklarLhBUq0fiyPGcqCOaF+7hgr7AMB2dKX638LZV6beXRUQeHKtJhL1k8yo/zirnnolE6j8Eg9zfe1TFGvo0OSDmmvKmX3S/8+eAfz0CA+rX03tYHqBWH+cJ6FVePMXRer5eyH77NBV4mYm+lhEOGIM/LpqVqWURETkQoxP0aMKh64uZhEDwu89s/MvOC8nBZJWGrq6FZbg7RgVuRnKECE2Vm9LlgY4k/xeE9qAcHzs8tFAEhYcuevsYHmtPlwvgEnQ2WRZNE3pS4cjQiaUqWbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bl2TmmHGzct09YP77wVUsBAOCUpcj3Yhm2ScBedTUVg=; b=GqEtildR/UgjBD4fh8cT3alNmwxFuWQknbMRwpkUB0iRlH7ZLBZ319dR1LNcd5Q4S16/GpogxYpiOerT27rKaj+BhKjBqYKvFUFuwXv7B9ePasiJLx7O9FYYXHwUOliXTdzz6y6k8Cogb4KX0qluBjGr9dhrOJNrHZ8ZHMkDy7X3zGFy+29x7TlAeJYj8KIHAD56JeSEQ0WzWXIZyYNCLwZmpio/K3NPS1NSiVasieXu0r/tt4bMqIbJfQWMJruDXFKnvZ9Mnw2u0tvkF30c57Z3nbE45tl62egyUQr5Ih5L4Yd4CuttFJ4TFSLjPW+bDhO3EW6VSy8VvcWX8qEDVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bl2TmmHGzct09YP77wVUsBAOCUpcj3Yhm2ScBedTUVg=; b=hk5AQYGz8D+hpSWlX7+ZZpY/rbQVAVAa6reUwE/45qy4uCDXyAF2Tzr5sakLRwln2lBiIakk7EUozHm4P9P5I0+ZcWiGTqcg9iRkiW+hYfiAlRLowgTjaiuwh1NgH6n100DFv1Ax5z5212effaK3XwmbkImoI4e/tDay9g1DEmyPq98FUjbV8rsMw+fMUEbuUZ5aCTbKVICAjn3tmXtF49L4K8LNOuxGyQ9CEij6DIuHVYrv7lXCTtQN5eK5MuGAETHZux1kfft6zKHEx/72c6JSon+kwHS1j/JALbRCq5rAoTUZ4yQZRLFt6KpCiMud6fPVva4f3RaF+YQvuib20g== Received: from SI2PR01MB5036.apcprd01.prod.exchangelabs.com (2603:1096:4:1f8::9) by SG2PR01MB3675.apcprd01.prod.exchangelabs.com (2603:1096:0:8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.32; Fri, 18 Aug 2023 06:43:21 +0000 Received: from SI2PR01MB5036.apcprd01.prod.exchangelabs.com ([fe80::6dd9:4ab1:e67e:c5b3]) by SI2PR01MB5036.apcprd01.prod.exchangelabs.com ([fe80::6dd9:4ab1:e67e:c5b3%4]) with mapi id 15.20.6678.031; Fri, 18 Aug 2023 06:43:21 +0000 Subject: Re: plist-check not reporting orphaned files present in a @comment To: ports@freebsd.org References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> <8raa-vofq-wny@FreeBSD.org> <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> <67hyj5pbnd2hf66tdj2szrtyhxozmjjcevw5rooas2vzrltxna@oqjzi7m5tfho> From: Tatsuki Makino Message-ID: Date: Fri, 18 Aug 2023 15:43:11 +0900 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Firefox/52.0 SeaMonkey/2.49.4 In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TMN: [jsUly4q5nvRWmIsFbGM65/kZbpRCz6YJ] X-ClientProxiedBy: SG2PR06CA0184.apcprd06.prod.outlook.com (2603:1096:4:1::16) To SI2PR01MB5036.apcprd01.prod.exchangelabs.com (2603:1096:4:1f8::9) X-Microsoft-Original-Message-ID: <1e5adce7-1e57-b798-2ab4-95422ee36001@hotmail.com> List-Id: Porting software to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-ports List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports@freebsd.org X-BeenThere: freebsd-ports@freebsd.org MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SI2PR01MB5036:EE_|SG2PR01MB3675:EE_ X-MS-Office365-Filtering-Correlation-Id: e4a7adb3-b784-4146-a56c-08db9fb6697b X-MS-Exchange-SLBlob-MailProps: AZnQBsB9Xmp/lAUbXAattpKgePYLWswqprzSLT9tr3Myam7skNb/DPW18f7XKfGfOA3hxbWvPI5QgWlSK9sKHr8AOdDFL3S2qrBNICejja4t1eSvwC5tmOb1t6I81occyUZJdsSKRkc2QhOiO7QqcD650p5jsOFFBIXj4NEHc8l+S8VMW+WWvvhqnbtY6m+w88pnQPA8KROIj5YF2EzhihNxmlo+BBwjG2cOeqAjT1zRQUsLyTKft2KpO+59/D4kcV1A4GGtTB6+tfMhX9tNa6WU3rHsg7CC/jhXP2IWkEjwWjVNzykvQv0UA0s9y0eN/hOYT0JlNCUTfW3X4C3D6Fi5PsvBYVa6dDU97QGHsXWowUNgsfUOn+L4cIajuJYtha2KcKkIovotd1u9upkfWIsJYacseHfvrNijAztQdF6BneXavill9MK2ViD51GyL6R4HbXkbmQNe47dZK3IICWdQpQrYQyK/TF5AslchXcMN58X/c1cNk7j/NacXbZ+DJMOv2fOA4SAHhx57QnFSyZqcHYfATvU8iqL9hXzmQYplOLGua27J2qUBQGzigfneO7D+nUSXUSGHa9Gk14iLMj13LdVnro+OKQnQQJZb7/a5AwBuFr6BN0Rh44Kt8cxLR5zP8rM5YUNDRQOkk14z7/t89lKFF8dMKJTSx7q0LhTXFmCzRAV1EuebklKiUcsgV4VHX8c9uPH7AR9Uw6IaACsHLTAW4hndWVjHtDLrovLayMLy44l6cvdKwL+rcR3ZAqToBXHfl0I= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oYtoa/Bd0iSmw5C4l2SopkcSP+RJxOeDWcZQFPhxnxaty+lB6bpJAgzGm2AdHvn817B4SvI2Owj+6SK6AMEtTsB249D5UWfxEhPWBVaqyuKf19Z3+OryEXUKDPM6OHObOkYDEO4X/IdA8BBGVeH0HPi6Hf3WWvdzPU3FwFORAbCyqKxs6iylulLYLOZbm765BvbqPZ3sCW4evKotV+6hKFIN2xA4juYTSIyT9QJKfAAYq8+A2AL4/rROcQDNUuKtZnrG0Ltzz6n2KJWvT/uPY+AdV5WkOGMblkeMgFzfDcKf1+UD9n+CBW4Ta5blK9rTk3c/n5ftYct+33tFN8F0y38ioZQovGZlw+V6NDN9n0kSoCmGduhD2H7TanLey6gFq9Z5p74bMSuXOPALA+A1DmyMAZoGL6YypeSifcEXMgVYC2E/ZR4+kOdeLnOMl6EjYlzbKHxw+oj5rr6juT9zH7TWSWOvtC6lC5dZMEvWNHQ3GzE4+LymCJJtcB42q6DBlZ+mmwWOJNh12+v5n6hTMuiM1+DEWP78g2f/OUuHe2L6/FS8fUxoCx8NE8oAQIzw6behhKC6s4nqgtN7q3L52tKnZdId4icsYYD4rODcoivjw4s+qR5NQWGpImVZlj+S X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2pJd01BOXRGM1JiQzBWTmVQQ0k5S0NGNGF3aGdSY0lRUkJDeTBTZmhyeEdS?= =?utf-8?B?QWp2ZDRvUEh4T3NhRnQwSEZBczJJQTBTRHIzOGpQRzdJZUFwV00wWDhaOFJT?= =?utf-8?B?U2k5Ymh2NkJxN00wdEtBeG96R095VHNVcG9oL1FNSWYrVlBkZmdmeWg3UjNP?= =?utf-8?B?Ync5ZWFNZ2NnSFl0KzVSYzAyOWxRNkpGM3RtcnVzZTlxQ1BTai9Hd2F2eWxy?= =?utf-8?B?UGdiNkdlczhOQ2owR3gzZUJWVTlJeHY4VVNLbWRyVXVtVkZtN0lhZm1zOEdU?= =?utf-8?B?Ymh0MFJTdUN4ZVMyZkpzQkRodWpLT0xTYVNIOXhHK1lsT3UydnZkRVFtUFlw?= =?utf-8?B?Z3d4Q245d2V4VmRQYXhQMVViVEV2SGtvVHgrem8zMHpDUlFxM08xL3lseWdQ?= =?utf-8?B?S2ZsNTFQZnBnVEFrZWFxdXdFa1V0dnNFRG9xcHRUYkFEdXpaazJSSzIzYTRu?= =?utf-8?B?czRWMkkzelE3QUxidEZCSzVLbFhXLzUvNzVYaGMyeUd4eXhLZFBXWW9oQ0xp?= =?utf-8?B?MTJWSzJIM0ZWTytDSVZoN0VlQndQRW5MZ2IzSWszYkN6QUJuUGg0bFNCKzFM?= =?utf-8?B?S0pnTDQyQXZ0bG40RW5naytQdGw0T0t1WHJlSnlEc0YwZTRxWFN3cDd1QXFj?= =?utf-8?B?bVFITENML0tNQXl2ekhsSDV5VjJ1ZFNhQnVYZ1hubmJjYTJXc2psTW96ZXdM?= =?utf-8?B?dEQ1VXNNUldESkkxUHgySncxdDFGNW16Y09ueDMvYzM0RzRFU0Vnc3V1ckNm?= =?utf-8?B?UjlSaEFxQTliaCt3ZHVPNFo3bHJDaDh4RHdpbFhKQXdjR0pnY2NlR3c4b2Ev?= =?utf-8?B?T2VNaWJxblZJQnp1eDVBY1BOZjU2aG1DVnBCVGN0ZGNkYUlTSmZFcktjWndV?= =?utf-8?B?SzFzcDVHcitPRE81N0E3WjRtQUJxa1paVVFRUUtsYVVxK2dXbHRMbWlxdEsv?= =?utf-8?B?VE9EaVdCcTJ6RGRKWEdRNXl2VlNvM2h3Rm9yQVZlMnNZY1UwcG91NHQzL2dN?= =?utf-8?B?Tzg4UlVKNVRqY1RzYlI3UlorYmhHTGVnektYaGJ0cVk5Mm1TekU2Wng0YTJn?= =?utf-8?B?elJtMmNGbnVpL1NqbnBYSnhLanpsSGJmaDFVM01GREJURHc3bGFYM2QxYTVJ?= =?utf-8?B?Nk5tYjVKaW1lMjZiY3BiRXVzWXBtTXAybm1kTDV5UmhKWDFPbmxBdEt6VW5h?= =?utf-8?B?M1FhVnpvQXpwem5YR0oxMkpNMml5SDBqNkYrUWNub2ZNZWdhUDA3U0FmOFVK?= =?utf-8?B?S0piSGxmclpEOS9vNlF2eUFtUmhjSmIyOFI4ZlliTG9TUmV0WmFBb2NtUk8v?= =?utf-8?B?UU5zdWhDMHlZdzl3TTBldFhSNDFXMlBmU0pva2xFaFRrT3VQdUJsWVN2ZDNY?= =?utf-8?B?ejBFTGs1eHpPR245a215S2RQcVRxSHVNK2ZsRldnc0JoT2pWUEpHZlJTRmdn?= =?utf-8?B?c3IrcHJjZVY0VFYyVWNTa1JSRmo0YjQxdjFOS1hqTU1xa1lzUFBoZUgwUnp1?= =?utf-8?B?UjRiQ1FGckFsV2ZJcDAzOGVMaGpmUVlPSXIyclB3dWdaVmY5OVpCd1VaUTdK?= =?utf-8?B?b3d6OGxKUmkxKzJqdjdXZEh3eGtuZVd2YnpZZGM5TlFmVUUxbVh3aCtzTHNP?= =?utf-8?Q?hBPHBUMGyjEq6JCv8n5xxjXKvYMJUiaDffWBV9ysZmnw=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-d8e84.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: e4a7adb3-b784-4146-a56c-08db9fb6697b X-MS-Exchange-CrossTenant-AuthSource: SI2PR01MB5036.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Aug 2023 06:43:21.0548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR01MB3675 X-Spamd-Result: default: False [-0.26 / 15.00]; FORGED_MUA_SEAMONKEY_MSGID_UNKNOWN(2.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; NEURAL_SPAM_SHORT(0.88)[0.880]; NEURAL_HAM_MEDIUM(-0.85)[-0.845]; DMARC_POLICY_ALLOW_WITH_FAILURES(-0.50)[]; R_DKIM_ALLOW(-0.20)[hotmail.com:s=selector1]; MIME_GOOD(-0.10)[text/plain]; DKIM_TRACE(0.00)[hotmail.com:+]; DMARC_POLICY_ALLOW(0.00)[hotmail.com,none]; ASN(0.00)[asn:8075, ipnet:40.80.0.0/12, country:US]; FREEMAIL_ENVFROM(0.00)[hotmail.com]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; MLMMJ_DEST(0.00)[ports@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.92.52.99:from]; RCPT_COUNT_ONE(0.00)[1]; FROM_HAS_DN(0.00)[]; R_SPF_FAIL(0.00)[-all]; RCVD_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[hotmail.com:dkim]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_FROM(0.00)[hotmail.com]; TO_DN_NONE(0.00)[]; RCVD_TLS_LAST(0.00)[] X-Spamd-Bar: / X-Rspamd-Queue-Id: 4RRslL0Mtvz4Yy2 I would like to confirm, plist-check is correct for make check-plist (or check-orphans), right? It is run by Mk/Scripts/check-stagedir.sh, and from looking at it's contents, it appears that some patterns are not reported as orphans. In the function check_orphans_from_plist(), they are lined up as a patterns of case. It doesn't match the pattern, does it? The following is just a quote attached. Regards. Felix Palmen wrote on 2023/08/18 03:00: > * Tatsuki Makino [20230817 17:14]: >> Felix Palmen wrote on 2023/08/17 15:03: >>> I might try another workaround, e.g. expand to "@comment dummy/" >>> instead, so the name won't match and plist-check will complain ... >> >> epson-inkjet-printer-escpr2 is easy because it is restricted to 2 architectures, but in general it seems difficult. >> How about also making a combined PLIST_SUB in Makefile? > > JFTR, this wasn't my problem here. In my concrete scenario, there are > only 3 supported archs anyways (I'm building a Linux-native toolchain > from source for the Linuxulator, will present it on this list once it > works on all 3 archs), and I already define NO_* subs, so it's straight > forward to set anything that might be required in pkg-plist. > > The issue really was just about plist-check, which will *not* report > "orphaned" files when they are present in some @comment... > > I now got around the issue using *this* block in my ports: > > #v+ > .include > > .if ${ARCH} == amd64 > PLIST_SUB+= AMD64="" NO_AMD64="@comment _nonexisting/" > .else > PLIST_SUB+= AMD64="@comment _nonexisting/" NO_AMD64="" > .endif > .if ${ARCH} == aarch64 > PLIST_SUB+= AARCH64="" NO_AARCH64="@comment _nonexisting/" > .else > PLIST_SUB+= AARCH64="@comment _nonexisting/" NO_AARCH64="" > .endif > .if ${ARCH} == i386 > PLIST_SUB+= I386="" NO_I386="@comment _nonexisting/" > .else > PLIST_SUB+= I386="@comment _nonexisting/" NO_I386="" > .endif > #v- > > Sure, it's somewhat dirty workaround, but adding some "dummy" prefix to > the files makes sure plist-check will complain about them ;) >