Re: libcrypto was not found in the pkg-config search path

> Hi,
> 
> Thanks for taking the time to test.
> Actually, the issue is only with the new kitty 0.26.2.
> Would it be possible for you to test this version on poudriere and confirm you also have this issue ?
> 
> 
> For the bug with libepoll-shim, we are waiting on Q4 : https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265017
> 
> Alexis

Yes, I confirm. I can reproduce this issue with the new version:

---
Package libcrypto was not found in the pkg-config search path.
Perhaps you should add the directory containing `libcrypto.pc'
to the PKG_CONFIG_PATH environment variable
Package 'libcrypto', required by 'virtual:world', not found
CC: ['cc'] (13, 0)
The package libcrypto was not found on your system
*** Error code 1

Stop.
make: stopped in /usr/ports/x11/kitty
---

I made some changes to the port to see if I can compile it:

---
diff --git a/x11/kitty/Makefile b/x11/kitty/Makefile
index 2d9229c9a5..f11ec0b588 100644
--- a/x11/kitty/Makefile
+++ b/x11/kitty/Makefile
@@ -1,5 +1,5 @@
 PORTNAME=	kitty
-DISTVERSION=	0.25.2
+DISTVERSION=	0.26.2
 PORTREVISION=	1
 CATEGORIES=	x11 wayland
 MASTER_SITES=	https://github.com/kovidgoyal/${PORTNAME}/releases/download/v${DISTVERSION}/
@@ -15,6 +15,7 @@ BUILD_DEPENDS=	${PYTHON_PKGNAMEPREFIX}furo>0:textproc/py-furo@${PY_FLAVOR} \
 		${PYTHON_PKGNAMEPREFIX}sphinx-copybutton>0:textproc/py-sphinx-copybutton@${PY_FLAVOR} \
 		${PYTHON_PKGNAMEPREFIX}sphinx-inline-tabs>0:textproc/py-sphinx-inline-tabs@${PY_FLAVOR} \
 		${PYTHON_PKGNAMEPREFIX}sphinxext-opengraph>0:textproc/py-sphinxext-opengraph@${PY_FLAVOR} \
+		openssl>0:security/openssl \
 		sphinx-build:textproc/py-sphinx@${PY_FLAVOR} \
 		wayland-protocols>=0:graphics/wayland-protocols
 LIB_DEPENDS=	libdbus-1.so:devel/dbus \
diff --git a/x11/kitty/distinfo b/x11/kitty/distinfo
index e2d938b113..3e11243fb1 100644
--- a/x11/kitty/distinfo
+++ b/x11/kitty/distinfo
@@ -1,3 +1,3 @@
-TIMESTAMP = 1660419246
-SHA256 (kitty-0.25.2.tar.xz) = a20a470490fee05bd4bd0ce0964b5b87df1fabe51f05fa076364bbfe2ee4e03c
-SIZE (kitty-0.25.2.tar.xz) = 4681940
+TIMESTAMP = 1663234885
+SHA256 (kitty-0.26.2.tar.xz) = 586ff599c5a3f31831b2a32dd9faafacb6c3581f2561f8ddcab0ba815bc7dab4
+SIZE (kitty-0.26.2.tar.xz) = 4716932
diff --git a/x11/kitty/pkg-plist b/x11/kitty/pkg-plist
index 1d5a72f7db..870f81dbc8 100644
--- a/x11/kitty/pkg-plist
+++ b/x11/kitty/pkg-plist
@@ -36,8 +36,7 @@ lib/kitty/kittens/mouse_demo/__init__.py
 lib/kitty/kittens/mouse_demo/main.py
 lib/kitty/kittens/panel/__init__.py
 lib/kitty/kittens/panel/main.py
-lib/kitty/kittens/prewarm/__init__.py
-lib/kitty/kittens/prewarm/main.py
+lib/kitty/kitty/prewarm.py
 lib/kitty/kittens/query_terminal/__init__.py
 lib/kitty/kittens/query_terminal/main.py
 lib/kitty/kittens/remote_file/__init__.py

---

I have sent the poudriere-testport log as an attachment. It can compile, but I have a doubt. I have added openssl as a build dependency, but I don't known if it is required also as a run dependency. I can't use kitty because my laptop is too old and my box where poudriere runs too, so it is necessary to check if kitty can run without problems. I guess so because fast_data_types.so depends on it, but check it.

The only error is in stage-qa:

---
Error: /usr/local/lib/kitty/kitty/fast_data_types.so is linked to /usr/local/lib/libcrypto.so.11 from security/openssl but it is not declared as a dependency
---

But when I add it:

---
All LIB_DEPENDS should use the new format and start out with lib. (libfoo.so
vs foo.so)
---

The library is in lib/kitty/kitty/fast_data_types.so.