Re: HEADS-UP: Upcoming move of WWW definitions in all ports

Am 08.09.22 um 03:59 schrieb Kubilay Kocak:
> On 7/09/2022 4:09 am, Stefan Esser wrote:
>> PortMgr has just accepted a change that has been in the making for some time:
>>
>> The move of the "WWW:" entries at the end of the ports' pkg-descr files into
>> the ports' Makefiles in the form of "WWW=" definitions.
> 
> Hi Stefan,
> 
> I'm seeing the following for the latest portsnap update, running make index 
> from ports root dir:
> 
> make[4]: don't know how to make describe. Stop
> ===> devel/py3c failed
> *** [describe.devel] Error code 1
> 
> Observed on both a CURRENT and 12-RELEASE (latest) machine.
> 
> Haven't dug into why yet, but thought it may be related to this change.

Hi Kubilay,

yes, commits to devel/py3c are blocked by a pre-commit hook.

When I tried to remove devel/py3c/Make3file from the WWW update,
I accidentally removed that file not from the staging area as
planned, but from the repository.

Since this is a remote pre-commit hook, my attempt to immediately
add the py3c/Makefile (pkg-descr file) back to the repository was
blocked, too.

I'm sorry, this can only be solved by either fixing or temporarily
disabling the pre-commit hook that blocks commits to devel/py3c
with the following message:

remote: ================================================================
remote: Adding new py3- ports is forbidden. File:
remote: devel/py3c/Makefile
remote: The Python ports have flavors and do not need the py3- ports.
remote: ================================================================

This message is clearly bogus and IMHO the pre-commit hook should
be taught about that specific port being exempted, or it should be
made stricter to prevent over-blocking as in in this case.

And BTW: the message was wrong during an attempted update of the
(still existing) Makefile when I tried to push the WWW update that
also touched the py3c port.

Regards, STefan