Re: cyrus-sasl dependency in bsd.ldap.mk

On 11/8/21 05:39, Juraj Lutter wrote:
> Hi Delphij,
> 
> you seem to be the most active in bsd.ldap.mk :-)
> 
> I’ve found that since openldap-client also depends on cyrus-sasl unconditionally, bsd.ldap.mk requires this:
> 
> otis@b13:/usr/ports/Mk % git diff -- bsd.ldap.mk
> diff --git a/Mk/bsd.ldap.mk b/Mk/bsd.ldap.mk
> index a6f37dd99b10..7acbc9c660bb 100644
> --- a/Mk/bsd.ldap.mk
> +++ b/Mk/bsd.ldap.mk
> @@ -77,6 +77,7 @@ IGNORE=               cannot install: doesn't work with OpenLDAP version: ${OPENLDAP_VER} (Do
>   .      endfor
>   .endif # IGNORE_WITH_OPENLDAP
>   LIB_DEPENDS+=  ${OPENLDAP${OPENLDAP_VER}_LIB}:net/openldap${OPENLDAP_VER}-client
> +LIB_DEPENDS+=  libsasl2.so:security/cyrus-sasl2
>   .else
>   IGNORE=                cannot install: unknown OpenLDAP version: ${OPENLDAP_VER}
>   .endif # Check for correct libs
> 
> What are you thought about it?

Could you provide an example that shows the breakage or elaborate more 
about why libsasl2.so needs to be listed as a direct library dependency 
for ports that depends on OpenLDAP?  It's already listed as LIB_DEPENDS 
in openldap*-{server,client} and installing the library should 
automatically bring in cyrus-sasl as needed, no?

Cheers,