[Bug 284187] devel/R-cran-systemfonts: Update to 1.2.0

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284187

Nuno Teixeira <eduardo@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open

--- Comment #2 from Nuno Teixeira <eduardo@FreeBSD.org> ---
Hello,

I strongly recommend to add knitr test depend so vignets could be tested too:

TEST_DEPENDS+= R-cran-knitr>0:print/R-cran-knitr

Also tests are failing:

<snip>
* checking tests ...
  Running 'testthat.R'
 ERROR
Running the tests in 'tests/testthat.R' failed.
Last 13 lines of output:
  == Failed tests
================================================================
  -- Failure ('test-match_font.R:19:3'): Font files can be found
-----------------
  tools::file_path_sans_ext(basename(font_path)) not equal to `font`.
  1/1 mismatches
  x[1]: "NimbusSans-Regular"
  y[1]: "DejaVuSans"
  -- Failure ('test-match_font.R:29:3'): Default font is correct
-----------------
  tools::file_path_sans_ext(basename(font_path)) not equal to `font`.
  1/1 mismatches
  x[1]: "NimbusSans-Regular"
  y[1]: "DejaVuSans"

  [ FAIL 2 | WARN 1 | SKIP 0 | PASS 5 ]
  Error: Test failures
  Execution halted
* checking for unstated dependencies in vignettes ... OK
* checking package vignettes ... OK
* checking running R code from vignettes ...
  'c_interface.Rmd' using 'UTF-8'... OK
 OK
* checking re-building of vignette outputs ... SKIPPED
* DONE
</snip>

My opinion and like I do to all cran ports that I maintain is to open a
upstream PR to solve the tests failures.

Also TESTING_UNSAFE should be added to port:

TESTING_UNSAFE= yes
or
TESTING_UNSAVE= <link to upstream PR>

Cheers

-- 
You are receiving this mail because:
You are the assignee for the bug.