[Bug 284878] sysutils/topgrade: Update to 16.0.2

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=284878

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ports-bugs@FreeBSD.org      |fuz@FreeBSD.org
             Status|New                         |In Progress

--- Comment #3 from Robert Clausecker <fuz@FreeBSD.org> ---
(In reply to freebsd from comment #2)

Again: because while it's often as easy as bumping a distversion and then
regenerating the distinfo, it isn't always.  Upstream may do random changes
that require your intervention as the package maintainer.  That's why as the
maintainer you need to (1) read the release notes (2) update the package (3)
test the port and check if it still works; this starts with a build test, then
running the test suite if applicable and then running the packaged tools to
check if they still do their job (4) check if there are any new bits that need
to be packaged and (5) adjust the package manually if needed.

I mean sure you can build some scripting to automate part (2), but that's by
far the easiest out of all the parts involved in updating a port.  I hope you
are also doing the other steps when you update your ports.  If not, you have
some work to do.  We want that the ports we ship actually work and aren't just
an unfiltered collection of random projects in various state of disrepair.

Now to continue, is there a changelog and could you provide me with a link to
it?
If not, could you summarise the upstream changes?

As for the garbage in Makefile.crates, I'm pretty sure you want to run "make
cargo-crates-merge" to update the file.  That's the target we have for this
purpose and it doesn't generate any garbage.  The fact that you didn't notice
the garbage in the file makes me seriously wonder how much review of the
generated patches you actually did.  Seems like you didn't even look at the
patch file.

As for your patch, there is an immediate issue in that you have used spaces for
indentation when you should use tabs.  Please make sure the port Makefile is
indented with tabs, not spaces.  I'll fix that for now, but please make sure
it's correct with your next patch.

Also finally, please check if you can submit future patches in
git-format-patch(1) format.  This makes it easier to deal with them as they
already have commit information.

-- 
You are receiving this mail because:
You are the assignee for the bug.