[Bug 281680] multimedia/x265: maintainer upgrade to 4.0

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281680

--- Comment #10 from Mikhail T. <freebsd-2024@virtual-estates.net> ---
(In reply to Robert Clausecker from comment #7)
> DEBUG_PREVENTS=         OPTIMIZED_FLAGS

Oh, that -- you said "ASM conflicts with DEBUG" earlier. That line is there
since 2021 -- by joneium@. It has nothing to do with the upgrade and may not
even be necessary any more, let me test.

> Is there a particular reason the ASM option isn't enabled by default?

It is enabled by default for some platforms -- but not others. Maybe, it should
be enabled for more -- perhaps, even all -- but, since I cannot test it, I was
being cautious. We can try...

> "git format-patch", not "git diff"

Don't you need to commit (even if locally) for format-patch to work? Since I
can no longer push anything, I avoid committing for fear of messing up a future
pull.

The `git diff HEAD -- .` is how I obtained the current patch.

(In reply to Vladimir Druzenko from comment #9)
> Oh, plz, without:
> .for o in ALPHA MULTIVIEW SCC_EXT SVTHEVC VMAF

The method is neither explicitly prohibited by any document, nor even
unprecedented -- take a look at the /usr/share/mk/gendirdeps.mk for example.
You don't have to use such single-letter variable-names yourself, but it
shouldn't be a show-stopper, if others do...

-- 
You are receiving this mail because:
You are the assignee for the bug.