[Bug 279816] Avoid defaulting to GH when USE_GITLAB and USE_GITHUB=nodefault is set

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 19 Sep 2024 12:49:24 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279816

--- Comment #1 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/ports/commit/?id=067905614d641e8a3fa3af3aa2d02b04a28b7185

commit 067905614d641e8a3fa3af3aa2d02b04a28b7185
Author:     Brad Davis <brd@FreeBSD.org>
AuthorDate: 2024-09-19 12:26:24 +0000
Commit:     Mathieu Arnold <mat@FreeBSD.org>
CommitDate: 2024-09-19 12:48:25 +0000

    Mk/bsd.sites.mk: don't add GH to MASTER_SITES when USE_GITHUB=nodefault

    When using USE_GITHUB=nodefault, we don't need to add GH to
    MASTER_SITES, as the github urls that are needed will be added later.

    Adding GH here means we'll add a generic GitHub URL to the fetch list,
    in the form of github.com/<portname>/<portname>/.../<dist> which will
    not work. When used with USE_GITLAB the framework will add this bogus
    URL before the correct gitlab url. It does not prevent the distfile to
    be fetched from gitlab, but it makes everyone try and fetch from a bogus
    url before trying the correct url.

    PR:     279816

 Mk/bsd.sites.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.