[Bug 281534] devel/py-Levenshtein: fix build with libc++ 19

From: <bugzilla-noreply_at_freebsd.org>
Date: Mon, 16 Sep 2024 12:11:14 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281534

            Bug ID: 281534
           Summary: devel/py-Levenshtein: fix build with libc++ 19
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: dvl@FreeBSD.org
          Reporter: dim@FreeBSD.org
          Assignee: dvl@FreeBSD.org
             Flags: maintainer-feedback?(dvl@FreeBSD.org)

As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes ports using devel/py-Levenshtein to fail to compile with
clang 19 and libc++ 19, resulting in errors similar to:

  /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined
template 'std::char_traits<unsigned int>'
    820 |   static_assert(is_same<_CharT, typename
traits_type::char_type>::value,
        |                                          ^
 
/wrkdirs/usr/ports/devel/py-Levenshtein/work-py311/Levenshtein-0.22.0/src/Levenshtein/Levenshtein-c/_levenshtein.hpp:144:43:
note: in instantiation of template class 'std::basic_string<unsigned int>'
requested here
    144 | static inline std::basic_string<uint32_t> lev_greedy_median(const
std::vector<RF_String>& strings,
        |                                           ^
  /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^

Unfortunately py-Levenshtein and its embedded copy of rapidfuzz-cpp make
heavy use of the no-longer-existing `std::basic_string<uint8_t>`, so I
had to do quite a lots of search and replace operations, replacing these
with equivalent `std::vector` types.

This is similar to the fixes for devel/rapidfuzz-cpp in bug 281193, and
for devel/py-rapidfuzz in bug 281194.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

-- 
You are receiving this mail because:
You are the assignee for the bug.