[Bug 281163] net-p2p/tremotesf: update to 2.7.0
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 281163] net-p2p/tremotesf: update to 2.7.0"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 02 Sep 2024 13:36:15 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=281163 --- Comment #5 from Anton Saietskii <vsasjason@gmail.com> --- (In reply to Daniel Engberg from comment #4) > No idea about status on that one but I'm going to guess that it's not > going to be merge anytime soon if ever. Can I help somehow to get traction? Proposed change looks very promising for me, but no any movement, including setting this to Abandoned is extremely confusing. > Upstream has already moved on Of course I'm aware of that, but it's not a duty of tremotesf or cpp-httplib authors to care about FreeBSD versions that don't have OpenSSL 3. Instead, it's my duty as a maintainer to keep port working on every supported FreeBSD version. > just mark it as broken on 13.X In fact, tremotesf isn't broken on 13, it works perfectly fine there. The only broken thing is cpp-httplib which is being used for 'test' target. However, I was explicitly asked to enable test support while porting tremotesf, so my priority is to keep tests working as well. Dealing with above isn't that easy, so here's issues to overcome: Moving to release assets usage leads to inability of putting httplib-0.14 without dirtiest possible hacks. Solution to that may be creating something like www/cpp-httplib014, but I doubt it makes sense for a port that has no consumers except tremotesf (at least, FreshPorts doesn't show them). With >=0.15, we will get broken 'test' target on 13. 'Solution' here ('ugly workaround' seems to be a better fit) is to disable cpp-httplib usage in tests, which luckily disables just 1 test out of 10. Tremotesf restricts upper cpp-httplib version to 0.16 at the moment [0], so tests are already broken even for FreeBSD >=1400092 due to ports commit 554573cc3ada283b9fea8869a68b06366971af5e. That means we can't unbundle httplib anyway, but luckily again, we can _prefer_ ports' version over bundled one, which is default. Actually I already have a patch which adresses above, just need to write a good commit message with decent rationale before sharing. [0]: https://github.com/equeim/tremotesf2/blob/2.7.0/cmake/FindCppHttplib.cmake#L8 -- You are receiving this mail because: You are the assignee for the bug.