[Bug 279003] [NEW PORT] sysutils/kleene-daemon Kleene backend component for managing containers on FreeBSD.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279003

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org,
                   |                            |olgeni@FreeBSD.org

--- Comment #4 from Robert Clausecker <fuz@FreeBSD.org> ---
Sorry for the delay.

Patch needs some improvements.  COMMENT should perhaps better read:

COMMENT= Kleene backend daemon for managing containers on FreeBSD

This is to avoid repetition in the comment, which is usually printed like

kleene-daemon  Kleene backend daemon for managing containers on FreeBSD

and with your old COMMENT it would have been

kleene-daemon  Kleened, the Kleene backend daemon for managing containers on
FreeBSD

repeating itself.

Please fix the indentation.  When editing ports Makefiles, make sure to set
your editor to hard tabs, 8 stops per tab.  Indent with at least two tabs for
make macros, one tab for make rules.  It's okay if you indent entire blocks of
macros deeper if that is needed to give all values the same indentation.

Please use USES=elixir if possible at all.  I have added olgeni@ as a reviewer,
who is more familiar with this stuff.

Do not install binaries with COPYTREE_SHARE, use COPYTREE_BIN instead (this
strips the binaries if needed).  If you do this right, you won't need to
explicitly strip any files.

libexec/kleened/releases does not seem to be an appropriate path for the erlang
files.  How do other erlang ports handle this?  Try to copy what they do.

Do not auto-generate the plist in post-install unless you have a very good
reason to do so.  "It's a lot of files" is not a good reason usually.  What is
your reason here?

-- 
You are receiving this mail because:
You are the assignee for the bug.