[Bug 282291] bsd.port.mk: Remove confusing double "/" from _DISTDIR

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 23 Oct 2024 20:19:13 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282291

            Bug ID: 282291
           Summary: bsd.port.mk: Remove confusing double "/" from _DISTDIR
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr@FreeBSD.org
          Reporter: 0mp@FreeBSD.org
                CC: ports-bugs@FreeBSD.org

bsd.port.mk: Remove confusing double "/" from _DISTDIR

_DISTDIR is a variable which stores the distfiles directory of the port that is
currently being worked on. In practice, it is usually just the DISTDIR,
although some ports also define a subdirectory. Currently, a slash separating
DISTDIR from DIST_SUBDIR is added to _DISTDIR no matter if DIST_SUBDIR is set
or not. This may cause confusion to ports users by looking like a bug while it
is not.

In particular, this patch casuses diagnostic logs of failed archive extraction
to look like this:

    ===>  Failed to extract "/portdistfiles/ttf-iosevka-ss05-4.1.1.zip".

instead of this:

    ===>  Failed to extract "/portdistfiles//ttf-iosevka-ss05-4.1.1.zip".

-- 
You are receiving this mail because:
You are on the CC list for the bug.