[Bug 283006] devel/libgit2: SSH option does nothing

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283006

            Bug ID: 283006
           Summary: devel/libgit2: SSH option does nothing
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: mfechner@FreeBSD.org
          Reporter: ahktenzero+freebsd@mohorovi.cc
             Flags: maintainer-feedback?(mfechner@FreeBSD.org)
          Assignee: mfechner@FreeBSD.org

Created attachment 255494
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=255494&action=edit
Patch for libgit2 Makefile

After some upgrades, noticed that my Salt masters using gitfs and git_pillar
were unable to fetch anything from the remote repositories I had configured.
After fixing some breakage in Salt due to changes in pygit2 I found I was left
with an error indicating that libgit2 was missing SSH support. I tested it
outside of Salt with a small Python script and got the same result. This was
surprising as I knew I had the SSH support enabled in the port (and it's on by
default), checking the installed libgit2 I found it wasn't linked against
libssh2. 

Dug into it some more, the option to enable SSH support was getting passed to
CMake during the port build but wasn't having any effect. Looking at the README
for libssh2, the USE_SSH option is now a choice of libssh2, extern, ON
(equivalent to libssh2) or OFF, so setting it with '-DUSE_SSH:BOOL=ON' wasn't
working. Also noticed that the THREADSAFE option isn't present in the CMakefile
any more and just produces an error during the build. 

Patch to correct handling for the SSH option and remove the unused THREADSAFE
option is attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.