[Bug 282733] [NEW PORT] textproc/dmenu-translate: Quick text translation with dmenu

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282733

--- Comment #5 from Robert Clausecker <fuz@FreeBSD.org> ---
Thanks.  If you can't use base sed, using GNU sed should be fine.

As for your current patch, it looks better.  Some things that need to be fixed:

 - do not invent a version number when upstream doesn't have one, instead
follow
   the example given in § 5.4.3 "USE_GITHUB" Example 17.
 - use the full git hash for GH_TAGNAME so it's unambiguous in any case
 - prefer DISTVERSION over PORTVERSION if possible
 - please check the grammar of your option descriptions; perhaps something like
   this would work?

    WAYLAND_DESC= depend on x11/wmenu and x11/wl-clipboard for use with Wayland
    X11_DESC= depend on x11/dmenu and x11/xclip for use with X11

 - our mktemp does not support --tempdir.  Please check the manual.  Perhaps
you
   want "mktemp -d dmenu-translate.XXXXXX'

Please check and resubmit if possible.  I'm sorry for not catching these issues
earlier.

-- 
You are receiving this mail because:
You are the assignee for the bug.