[Bug 282733] [NEW PORT] textproc/dmenu-translate: Quick text translation with dmenu

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 26 Nov 2024 15:13:22 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282733

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> ---
MASTER_SITES doesn't need to be set if you use USE_GITHUB.

I see that you have forked upstream's repository to add portability patches. 
We strongly prefer not to do this, as this makes it hard to go back to the real
upstream if your fork stops being maintained.  Instead, use the real upstream
and apply the portability patches locally using patch files.  See § 4.4
"Patching" Porter's Handbook for details.

Is it possible to adapt the sed usage to our sed instead of depending on GNU
sed?  This would be preferable, but using GNU sed is fine.

PORTEXAMPLES doesn't work the way you use it.  Check § 5.17.4 "Install
additional documentation" for how to use it.

The RUN_DEPENDS stuff depending on Wayland/X11 is a bit annoying; most users
install binary packages, so this package won't be usable as precompiled for
Wayland users.  Not sure what the best solution is.

-- 
You are receiving this mail because:
You are the assignee for the bug.