[Bug 282527] graphics/ogre3d19: fix build with libc++ 19

From: <bugzilla-noreply_at_freebsd.org>
Date: Sun, 03 Nov 2024 22:59:28 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=282527

            Bug ID: 282527
           Summary: graphics/ogre3d19: fix build with libc++ 19
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: amdmi3@FreeBSD.org
          Reporter: dim@FreeBSD.org
             Flags: maintainer-feedback?(amdmi3@FreeBSD.org)
          Assignee: amdmi3@FreeBSD.org

As noted in the libc++ 19 release notes [1], std::char_traits<> is now
only provided for char, char8_t, char16_t, char32_t and wchar_t, and any
instantiation for other types will fail.

This causes graphics/ogre3d19 to fail to compile with clang 19 and
libc++ 19, resulting in errors similar to:

  /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined
template 'std::char_traits<unsigned short>'
    820 |   static_assert(is_same<_CharT, typename
traits_type::char_type>::value,
        |                                          ^
 
/wrkdirs/usr/ports/graphics/ogre3d19/work/sinbad-ogre-dd30349ea667/OgreMain/include/OgreUTFString.h:234:4:
note: in instantiation of template class 'std::basic_string<unsigned short>'
requested here
    234 |                         dstring::iterator mIter;
        |                         ^
  /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here
     23 | struct _LIBCPP_TEMPLATE_VIS char_traits;
        |                             ^

This can be fixed by defining `unicode_char` as `char32_t` instead of
`uint32`, and `code_point` as `char16_t` instead of `uint16` in
`OgreUTFString.h`.

[1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals

-- 
You are receiving this mail because:
You are the assignee for the bug.