[Bug 277333] Mk/Features/lto.mk: passing -C lto=no breaks LTO_UNSAFE ports

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 26 Mar 2024 16:52:01 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277333

--- Comment #14 from Jan Beich <jbeich@FreeBSD.org> ---
Consumers cannot drop LTO_UNSAFE (to match Cargo.toml) and override
CARGO_PROFILE_RELEASE_PANIC due to Mk/Features/lto.mk appending CARGO_ENV after
(the last assignment wins) ports' own CARGO_ENV. For example, the following
restores the regression (see inline comment) introduced by ports 967022fd812c.

$ make -V CARGO_ENV:M\*PANIC\*
CARGO_PROFILE_RELEASE_PANIC=unwind CARGO_PROFILE_RELEASE_PANIC="abort"

diff --git a/devel/texlab/Makefile b/devel/texlab/Makefile
index 5ae2bf759953..3cc9eab3cd51 100644
--- a/devel/texlab/Makefile
+++ b/devel/texlab/Makefile
@@ -17,7 +17,7 @@ GH_ACCOUNT=   latex-lsp

 # Fixes: error: the linked panic runtime `panic_unwind` is not compiled with
 # this crate's panic strategy `abort`
-LTO_UNSAFE=    yes
+CARGO_ENV=     CARGO_PROFILE_RELEASE_PANIC=unwind

 PLIST_FILES=   bin/${PORTNAME} \
                share/man/man1/${PORTNAME}.1.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.