[Bug 277902] Mk/Uses/cargo.mk: WITH_LTO no longer applies

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 23 Mar 2024 07:35:22 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277902

            Bug ID: 277902
           Summary: Mk/Uses/cargo.mk: WITH_LTO no longer applies
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr@FreeBSD.org
          Reporter: diizzy@FreeBSD.org
                CC: arrowd@FreeBSD.org, bapt@FreeBSD.org,
                    mikael@FreeBSD.org, pkubaj@FreeBSD.org,
                    ports-bugs@FreeBSD.org

WITH_LTO no longer gets applied when being called from Mk/Uses/cargo.mk, it
does however work if you define it in a port.

Example:

make -V CARGO_ENV
CARGO_HOME=/usr/ports/audio/ebur128/work/cargo-home  CARGO_BUILD_JOBS=6 
CARGO_BUILD_TARGET=x86_64-unknown-freebsd 
CARGO_TARGET_DIR=/usr/ports/audio/ebur128/work/target 
CARGO_TARGET_X86_64_UNKNOWN_FREEBSD_LINKER="cc"  RUSTC=/usr/local/bin/rustc 
RUSTDOC=/usr/local/bin/rustdoc  RUSTFLAGS="-C target-cpu=tigerlake -C
link-arg=-fstack-protector-strong" RUST_BACKTRACE=1

Adding WITH_LTO=yes to port Makefile:

CARGO_HOME=/usr/ports/audio/ebur128/work/cargo-home  CARGO_BUILD_JOBS=6 
CARGO_BUILD_TARGET=x86_64-unknown-freebsd 
CARGO_TARGET_DIR=/usr/ports/audio/ebur128/work/target 
CARGO_TARGET_X86_64_UNKNOWN_FREEBSD_LINKER="cc"  RUSTC=/usr/local/bin/rustc 
RUSTDOC=/usr/local/bin/rustdoc  RUSTFLAGS="-C target-cpu=tigerlake -C
link-arg=-fstack-protector-strong" RUST_BACKTRACE=1
CARGO_PROFILE_RELEASE_LTO="true"  CARGO_PROFILE_RELEASE_PANIC="abort" 
CARGO_PROFILE_RELEASE_CODEGEN_UNITS=1

Commit d697653cffd19ddaf3cdee2589a830c72ab39777 broke this functionality

-- 
You are receiving this mail because:
You are on the CC list for the bug.