[Bug 277348] x11/wmctrl: upstream no longer exists

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277348

Felix Palmen <zirias@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zirias@freebsd.org
             Status|New                         |Open
           Assignee|ports-bugs@FreeBSD.org      |zirias@freebsd.org

--- Comment #2 from Felix Palmen <zirias@freebsd.org> ---
Hi and thanks for your contribution!

First I have a question: Did you attempt to contact the original upstream
maintainer? If not, could you please do so? I think it's important because
otherwise, it's unclear whether "wmctrl-1.09" would refer to your fork or maybe
to some other fork.

If the original upstream maintainer isn't available, or unwilling to pass
upstream maintainership, I'd very much prefer a different name (maybe just
adding some prefix or suffix) to avoid any confusion. Or maybe as another
option, host the original distfile somewhere along with a patch to make it work
(and then of course keep the version at 1.07).

This aside, you probably want to clean your github fork from all GNU autotools
generated files. To avoid having to use USES=autoreconf, the best option is to
generate an actual disfile (IIRC GNU autotools supports "make dist" for that)
and upload it to a release on github ... thus also avoiding the need for
USE_GITHUB=yes.

Finally, at a first glance, please don't add to variables when not needed, like
here:

USE_XORG=       x11 xmu xext xt
USE_XORG+=      ice
USE_XORG+=      sm

The correct way would be

USE_XORG=       ice sm x11 xext xmu xt

(alphabetically sorted)

-- 
You are receiving this mail because:
You are the assignee for the bug.