From nobody Fri Jul 26 04:26:17 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WVZSn48j4z5RGMW for ; Fri, 26 Jul 2024 04:26:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WVZSn35xQz419g for ; Fri, 26 Jul 2024 04:26:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1721967977; a=rsa-sha256; cv=none; b=FkImTg9wfDjUoSl+syBt82WhI28JXxcvpe5mExDoNOsx81SPxrL5zTDFiNyFyNeKBcLsaw W/fEV6aa0ibGphV14Jh6v8EAsMcxqdPQo2oAtXm2bCwtl7mLn7IduqIZ1DXTCG6AmflcAC jEys2MsuUqHv/QOSVJTH5Skf44GLbz2OTHre8gwl9nGGG4OS3Ay0feXhNTCuQnLF1CAWSB ENdN4r5zXyTrS0HoXp4no+2I4/lYB1Uff40XO/FT86ric4ODwQHlwiyr+xqLFkYasHo9rr KZNNY6XcbjZA/Xj9cWboXp8IymLqiTuT9l+B3v46MayP19VKKc09Z85cHoyAHQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1721967977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JVNvKb+r4KTEUUO51/Jm2ygnPbnHMrUPcbrXxUoE3M0=; b=vGwSF4u73j1oNuXkpmtYZr7p7g1of+3ELTICynoXXNtf7Ilt/Nog2T3JKAmdAGxltu+xfU IeMEKH51iqr8tFXBxX3ecSb0E0A8mah3896yZURyaD/fhgTY37iCBHBnxmShFBvy0cqG9w jhmayt2uoeiAn+W/UDzf795VbWiwYAUbcvj4WaOy3VBDvVrr4HUoT0gnMBZslPB9yk/E7l q84qyB6YQfszitIXGv64iQYdtiOfoZLYPGvLHiJY5DRbx+GE2o01lQ5P3yCYWmlr2Jbn4I VKpO8YbCEKzC137y9jrO4aDSBo0yrkUX6WoW/UMsOOsFr6R9MYhsMrYbn4i9jg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WVZSn2hkQz1NNW for ; Fri, 26 Jul 2024 04:26:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 46Q4QH3q070368 for ; Fri, 26 Jul 2024 04:26:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 46Q4QHcw070367 for ports-bugs@FreeBSD.org; Fri, 26 Jul 2024 04:26:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 280396] Mk/Uses/cmake.mk: Disallow USE_CSTD and USE_CXXSTD Date: Fri, 26 Jul 2024 04:26:17 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jhale@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: kde@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280396 --- Comment #7 from Jason E. Hale --- (In reply to Daniel Engberg from comment #5) > I'm not against utilizing USE_C*STD however I do think it also introduces= more "framework quirks" which might not be desirable. People are already s= truggling with remembering "common" helpers/macros and I don't think we nee= d to add more especially ones that have never been "announced" as in never = been mentioned in Porters Handbook. I don't quite follow. USE_CSTD and USE_CXXSTD are standard variables and are neither "framework quirks" nor remotely anything new. USE_CXXSTD and USE_CSTD were introduced over 10 [1] and 15 years ago [2] ye= ars ago, respectively. True, they are not mentioned anywhere in the PHB, but neither are USE_BINUTILS nor USE_LOCALE. Are you going after them next? The= PHB is an excellent guide, but isn't a complete truth source and using it as su= ch is a weak argument. Even the ports(7) manpage admits that the spread-out na= ture of ports documentation is a bug. Who is struggling, though? Maybe some contributors aren't always going to be making the right calls, but committers should definitely be familiar with b= asic ports infrastructure and correct those mistakes. The beauty of the ports framework is being able to quickly build a project without necessarily having to know the peculiarities of every build system, with the more detailed work being handled "behind the scenes" for the porte= r. It's basically an abstraction layer that I would expect to handle its own standard variables appropriately and not chide the porter for using them. > While BROKEN might be a bit too agressive I think there's benefit in bein= g a bit strict in this case as it makes overall maintaince easier, more con= sistent than having multiple ways to approach the same issue in. Who's maintenance time is being enhanced by converting standard ports varia= bles into lesser-known arguments in individual Makefiles, when this could be more easily abstracted by the framework? Consistency is good and we have tools to check for the important things, but there's more than one right way to do the rest. For example, I personally prefer using pipes (|) as delimiters in REINPLACE_CMD arguments, but some u= se slashes (/) or commas (,). [1] https://cgit.freebsd.org/ports/commit/Mk/bsd.port.mk?id=3Dc3f673a223b029873= a4625dfbd7c74de0430f1fb [2] https://cgit.freebsd.org/ports/commit/Mk/bsd.port.mk?id=3Dab5c91839fead28a4= 6d188b7e895a5a96baad9db --=20 You are receiving this mail because: You are on the CC list for the bug.=