[Bug 280340] [NEW PORT] math/quich: a terminal calculator

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 20 Jul 2024 11:04:33 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280340

--- Comment #5 from gatekeeper <tiago.gasiba@gmail.com> ---
(In reply to Daniel Engberg from comment #4)

quich is already linking against libm; see here in the compiled file:
.build/quich:
        libm.so.5 => /lib/libm.so.5 (0x15766118000)
        liblinenoise.so => /usr/local/lib/liblinenoise.so (0x15767656000)
        libc.so.7 => /lib/libc.so.7 (0x15766f75000)
        [vdso] (0x15765310000)

I was thinking that you might be referring to the patch for the Makefile, but
it is linking to libm... the patch just adds liblinenoise (and does not remote
libm) to both quich and quich_test. After applying the patch, the Makefile
looks like this (for quich):

target_link_libraries(quich m)
target_link_libraries(quich linenoise)

I was also wondering if you were referring to a missing LIB_DEPENDS on the
port's Makefile, but I cannot find any other example in the ports tree that
does this; Since libm is part of base, I guess that this is not needed and your
comment is not referring to this... right?

So... sorry, I am not sure what you are referring to - can you please elaborate
a bit more? :-)

Thanks for taking the time to review.

-- 
You are receiving this mail because:
You are the assignee for the bug.