[Bug 280298] net/miniupnpc: in 2.2.8 changed API for UPNP_GetValidIGD: build error net-p2p/transmission-components and other

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 17 Jul 2024 09:10:35 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280298

--- Comment #38 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/ports/commit/?id=263d5293fc66e3f9f48a8cc3217235fb933d1f08

commit 263d5293fc66e3f9f48a8cc3217235fb933d1f08
Author:     Anton Saietskii <vsasjason@gmail.com>
AuthorDate: 2024-07-17 09:03:29 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-07-17 09:09:29 +0000

    net-p2p/transmission-components: Fix build with miniupnpc-2.2.8

   
/usr/ports/net-p2p/transmission-components/work-cli/transmission-4.0.6/libtransmission/port-forwarding-upnp.cc:278:13:
    error: no matching function for call to 'UPNP_GetValidIGD'
      278 |         if (UPNP_GetValidIGD(devlist, &handle->urls,
    &handle->data, std::data(lanaddr), std::size(lanaddr) - 1) ==
          |             ^~~~~~~~~~~~~~~~
    /usr/local/include/miniupnpc/miniupnpc.h:122:1: note: candidate function
    not viable: requires 7 arguments, but 5 were provided
      122 | UPNP_GetValidIGD(struct UPNPDev * devlist,
          | ^                ~~~~~~~~~~~~~~~~~~~~~~~~~
      123 |                  struct UPNPUrls * urls,
          |                  ~~~~~~~~~~~~~~~~~~~~~~~
      124 |                  struct IGDdatas * data,
          |                  ~~~~~~~~~~~~~~~~~~~~~~~
      125 |                  char * lanaddr, int lanaddrlen,
          |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      126 |                  char * wanaddr, int wanaddrlen);
          |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    ninja: build stopped: subcommand failed.
    *** Error code 1

    PR:             280298
    Approved by:    Rafe <mondo.debater_0q@icloud.com> (maintainer)
    Obtained from: 
https://github.com/transmission/transmission/commit/febfe49ca3ecab1a7142ecb34012c1f0b2bcdee8

 .../patch-libtransmission_port-forwarding-upnp.cc (new) | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

-- 
You are receiving this mail because:
You are the assignee for the bug.