[Bug 280217] archivers/lxqt-archiver: package has less dependencies than the port requires (14)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280217

            Bug ID: 280217
           Summary: archivers/lxqt-archiver: package has less dependencies
                    than the port requires (14)
           Product: Ports & Packages
           Version: Latest
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs@FreeBSD.org
          Reporter: kreinholz@gmail.com

Build system info:

FreeBSD 14.1-STABLE (amd64)
Kernel Version 1401501, Userland Version 1401501, Revision n267971
synth-2.13_2
LLVM version 18.1.6

Building archivers/lxqt-archiver with ports-mgmt/synth results in the following
obsolete packages warning being logged:

archivers/lxqt-archiver package has less dependencies than the port requires
(14)

devel/desktop-file-utils:desktop-file-utils-0.27
devel/gettext-runtime:gettext-runtime-0.22.5
devel/glib20:glib-2.80.3,2
archivers/gtar:gtar-1.35_1
devel/json-glib:json-glib-1.8.0
graphics/libexif:libexif-0.6.24
x11/libfm-qt6:libfm-qt6-2.0.2
devel/liblxqt:liblxqt-2.0.0
devel/libqt6xdg:libqt6xdg-4.0.0
x11/libxcb:libxcb-1.17.0
x11/menu-cache:menu-cache-1.1.0
lang/perl5.36:perl5-5.36.3_1
devel/qt6-base:qt6-base-6.7.2

This warning began when lxqt-archiver was updated from version 0.8.0 to 0.9.0,
and continues with the current version 1.0.0.

The culprit appears to be the following change to the Makefile:

diff --git a/archivers/lxqt-archiver/Makefile
b/archivers/lxqt-archiver/Makefile
index 17bfb2616957..423836ef9c12 100644
--- a/archivers/lxqt-archiver/Makefile
+++ b/archivers/lxqt-archiver/Makefile
@@ -1,5 +1,5 @@
 PORTNAME=      lxqt-archiver
-PORTVERSION=   0.8.0
+PORTVERSION=   0.9.0
 CATEGORIES=    archivers
 MASTER_SITES=  LXQT

@@ -13,15 +13,14 @@ LIB_DEPENDS=        libfm-qt.so:x11/libfm-qt \
                libjson-glib-1.0.so:devel/json-glib \
                libmenu-cache.so:x11/menu-cache \
                libexif.so:graphics/libexif
-RUN_DEPENDS=   ${LOCALBASE}/bin/gtar:archivers/gtar \
-               ${LOCALBASE}/bin/unzip:archivers/unzip
+RUN_DEPENDS=   gtar:archivers/gtar \
+               unzip:archivers/unzip

Previously, lxqt-archiver looked for gtar and unzip in /usr/local/bin, and
dependencies were logged properly. However, starting with the above commit, it
began searching for these binaries in /usr/bin, and falling back on
/usr/local/bin only if not found in the base system.

gtar is not included in the FreeBSD 14.1 base system; unzip is. As a result,
unzip doesn't get logged as a dependency, and synth logs a warning about
lxqt-archiver having less dependencies than the port requires.

Reverting the run depends check for unzip to
${LOCALBASE}/bin/unzip:archivers/unzip results in synth correctly building
lxqt-archiver and logging the appropriate dependencies, resolving this warning
message.

Since unzip is included in the FreeBSD base system, this runtime dependency
check could alternatively be eliminated from the Makefile altogether, unless it
is always desired to build against the archivers/unzip port, which provides
UnZip, as opposed to the base system bsdunzip.

Note: because I have x11-wm/lxqt in my prime packages list, the above
dependency mismatch logs a warning but does not uninstall either lxqt-archiver
or lxqt.

--- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> ---
Maintainer informed via mail

-- 
You are receiving this mail because:
You are the assignee for the bug.