[Bug 283516] textproc/ibus: update to 1.5.31

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=283516

--- Comment #1 from Henry Hu <henry.hu.sh@gmail.com> ---
On the high level this looks good, I have a few comments, though:

1. I know vulkan and graphene are listed as 'requirements' in gtk4.pc. Do you
think that we should list them as dependencies of this port, though?

This port does not use them directly; instead, they're depended upon indirectly
through GTK4, right? So we possibly should just have GTK4 depend on them?
If you check the code, actually gtk2 & gtk3 plugins also use graphene, but
they're not listed.

I suppose removing them creates warnings in stage-qa? I still lean towards not
having them as direct dependencies, though, at least not vulkan - we do have
some code which uses graphene, although the code does not even include its
header. I think the code possibly should be fixed upstream...

My opinion on this is not very strong, though. If you want to keep them to
avoid the warning, I'm okay with that.

2. I think removing the BUILD_DEP on gtk-doc is not fully correct; it should be
there when the DOCS option is enabled, otherwise, it'll be detected as missing
during configure, and docs would not be built.

3. This is not relevant to this change, but it seems like that we're missing a
bunch of html files in the pkg-plist, if the DOCS option is enabled.
I don't know why we didn't notice this earlier, but we should install them, I
think. This is discovered through `make check-plist`.

-- 
You are receiving this mail because:
You are the assignee for the bug.