From nobody Mon Aug 26 22:55:26 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Wt5cG3kxgz5Tlt6 for ; Mon, 26 Aug 2024 22:55:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Wt5cG20mMz4YNk for ; Mon, 26 Aug 2024 22:55:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1724712926; a=rsa-sha256; cv=none; b=r3Fg0bcJQOzJTSY2wpQP05GFVdmSXjBkdwhASHmS7nKsrLzTsdxqOvUZi7xCtyBk+0mW1Q 3vnLU6zQedxuWYiHb3OIO5H3jjdBvO1x0gqpzNCikrQIK8qe9TPPn1vex15cG5qlJ8Sa+l qJkho/lq6Cqf5bb3EycX5GuaaidyBmeyW71fa+2nHMoG1wpRVe1PbrGmz3ao28uhEM00Ma CiW7lRI8vBKpZIFMlch+j2D06bUJt2G7FNb04U54fwLUuR1CcBS/synLw9CV6Uh5G45Zcz Y0dG6RN+X5akfiXcBFh6k7dNH9jCmbX50a+lZFc9ch17C7PNQRv5mvSxEAM+GQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1724712926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zm680kH+rMT5U58u8KvZlFhcT+/c09p7sfW+Oh2D0rE=; b=UknPwMIVxofRY+hd5gFF5tkDjGdaOSNwaQ7aiJSbgZzAAhuShhyQ6dOC9GryUCV6sYCfoB 2Ds8MhQjy990R5sZ5uaKz3ZmW6f/XUsfA631ZkN49Xovdz9/LBxljn7C+ujLT+CtQfdcGe /uRYNMqJoSslOUxTCzXVtyuEkEK07Wl+/AX9ysS421hQ1zeRLVDNLCFMzJAXx3IvvgqB5+ fZGQYIO/pS2pHw74u/285eQMWUseeEhR8SQbjhnrV8j6+PExlfDc3ktvOWBBSHkCXM5OQC uuhn/6xEFHYeWE6qyUQbH8+yNdukQ9Op1o7hLkByjL76XUOdGtqXiBhZTMfmXQ== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Wt5cG1cf0zQKx for ; Mon, 26 Aug 2024 22:55:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 47QMtQOD034494 for ; Mon, 26 Aug 2024 22:55:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 47QMtQch034488 for ports-bugs@FreeBSD.org; Mon, 26 Aug 2024 22:55:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 281080] emulators/ares: update to 139.20240825 and unbundle librashader dependency Date: Mon, 26 Aug 2024 22:55:26 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: bsdcode@disroot.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D281080 --- Comment #2 from Stefan Schlosser --- The relationship between ares and librashader is this: ares bundles a local copy of the complete librashader sourcecode under ${WRKSRC}/thirdparty/librashader. The only things ares really needs and uses from it are the includefiles include/librashader.h and include/librashader_ld.h. But this is mandatory, ares won't compile without them. At runtime it isn't a hard dependency, it tries to dynamically load ${LOCALBASE}/lib/librashader.so and if it succeeds then shaders work, if it doesn't succeed then shaders don't work. If it wouldn't be an unconditional build dependency then we could control everything related to librashader behind the SHADER portoption, i.e. * use SHADER_LIB_DEPENDS=3Ddevel/librashader instead of BUILD_DEPENDS + SHADER_RUN_DEPENDS * use SHADER_CFLAGS=3D-DLIBRA_RUNTIME_OPENGL instead of CFLAGS * use ${REINPLACE_CMD} for librashader_ld.h in post-patch-SHADER-on instea= d of in post-patch * use ${REINPLACE_CMD} 's|-I../thirdparty/librashader/include||g' ${WRKSRC}/desktop-ui/GNUmakefile in post-patch-SHADER-on instead of inside = the desktop-ui_GNUmakefile patch itself Now, we can do exactly this, but because librashader is an unconditional bu= ild dependency we have the following situation: * SHADER on: ares build uses includefiles from devel/librashader * SHADER off: ares build uses bundled includefiles With my current updatepatch we just always use the includefiles from devel/librashader. What are you recommending? --=20 You are receiving this mail because: You are the assignee for the bug.=