[Bug 280734] [NEW PORT] deskutil/ximaging: Image Viewer and Browser for Unix/X11

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280734

--- Comment #1 from Vladimir Druzenko <vvd@FreeBSD.org> ---
1. Alphabetically sort records:
LIB_DEPENDS+=   libtiff.so:graphics/tiff libpng16.so:graphics/png
USES=           tar:xz motif jpeg
USE_XORG=       xt xinerama x11
=>
LIB_DEPENDS=    libpng16.so:graphics/png \
                libtiff.so:graphics/tiff
USES=           jpeg motif tar:xz
USE_XORG=       x11 xinerama xt

2. Not needed "+": LIB_DEPENDS+= => LIB_DEPENDS=

3. CATEGORIES=deskutils, why not graphics?

4. Try to replace DISTNAME=ximaging-src-${DISTVERSION} with
DISTVERSIONPREFIX=src-

5.
${INSTALL_PROGRAM} ${WRKSRC}/src/ximaging ${STAGEDIR}${PREFIX}/bin/ximaging
=>
${INSTALL_PROGRAM} ${WRKSRC}/src/${PORTNAME} ${STAGEDIR}${PREFIX}/bin

${INSTALL_MAN} ${WRKSRC}/src/ximaging.1
${STAGEDIR}${PREFIX}/share/man/man1/ximaging.1
=>
${INSTALL_MAN} ${WRKSRC}/src/${PORTNAME}.1 ${STAGEDIR}${PREFIX}/share/man/man1

6. Less than 6 lines in pkg-plist recommended to replace with PLIST_FILES in
Makefile:
PLIST_FILES= bin/ximaging \
             etc/X11/app-defaults/XImaging \
             share/man/man1/ximaging.1.gz

-- 
You are receiving this mail because:
You are the assignee for the bug.