From nobody Fri Aug 09 17:36:01 2024 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4WgWKY38QRz5SV1D for ; Fri, 09 Aug 2024 17:36:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4WgWKY009wz45Vp for ; Fri, 9 Aug 2024 17:36:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1723224961; a=rsa-sha256; cv=none; b=UcwVHy2T+4rNQ9vNP4OBQHNUsTa2uOo5TLFuy61igcVu0T6vT0PQp5gJEUanvNUmPaenx+ EvA2two8yAq4tHl3rC68dhHI3VpqxSaO0unzjrS1IH7oXFOUA5/g2s1HfHvg30u/I+vhPo /EFT7UFIa/aqYLQSHMSkRvzMgXOWictH4OtsXaWFa4t8o2XGo3Rdb4rlgCtkDXjfUsHTEF iiFTyrO8UALUIcwYAv4mZGunLypUBoFZmKfnEx09+T+hLFNrn5l7Ot++guH6lq2ghuhR63 4+K3Az/LE/5amyDfKpKtLnEZWVoSiQvEgz5QCKyB8wjXW1KY3Y1WXRvByO7Y5g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1723224961; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=10T4+Ws8j3Z8tCnil6/ak5wIwZxc5HnKN/dfD7/lALs=; b=v5evS2bXk2PkSJitTKLm30tXewk+19d/axUv/JWOjKzUEkkyMHHqxBw/WHSprfGNDIwae8 16WMK76bYBQ6DMOITMrvj/xV9P9Wq81QlBhAqqBvHW/XeSUC1CkQgAh1srLzoqQtp55zW3 M887pDBeQ555MPKhBxptGUcMBL1sQWSglBVV60gA8tOBxXJqJrzCDQlcJt92PN3iTXphR/ mA5RbtJOKiBJ5A0GlnysDpAOdyuUCubNr8L/vPQ4TTqtncC+nkZZi157dt0/nGmjjtKdpE TntaYAUdOdxQF8S80m6VmpVZFzb+ckLlb9wCUEgLl8MTqsm2sGJApPQpMmtcyA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4WgWKX5TR5zQXx for ; Fri, 9 Aug 2024 17:36:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 479Ha0kL018761 for ; Fri, 9 Aug 2024 17:36:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 479Ha0is018760 for ports-bugs@FreeBSD.org; Fri, 9 Aug 2024 17:36:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 280696] net/kea: fix build with libc++ 19 Date: Fri, 09 Aug 2024 17:36:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: freebsd-ports-bugs@freebsd.org Sender: owner-freebsd-ports-bugs@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280696 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3Deddc2f815b3fac6d363e93e7f9ec4da= bc816b0c9 commit eddc2f815b3fac6d363e93e7f9ec4dabc816b0c9 Author: Dimitry Andric AuthorDate: 2024-08-08 18:34:30 +0000 Commit: Dimitry Andric CommitDate: 2024-08-09 17:34:46 +0000 net/kea: fix build with libc++ 19 As noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. This causes net/kea to fail to compile with clang 19 and libc++ 19, resulting in errors similar to: In file included from edns.cc:9: In file included from ../../../src/lib/exceptions/exceptions.h:11: /usr/include/c++/v1/string:820:42: error: implicit instantiation of undefined template 'std::char_traits' 820 | static_assert(is_same<_CharT, typename traits_type::char_type>::value, | ^ ../../../src/lib/dns/name.h:727:16: note: in instantiation of templ= ate class 'std::basic_string' requested here 727 | NameString ndata_; | ^ /usr/include/c++/v1/__fwd/string.h:23:29: note: template is declared here 23 | struct _LIBCPP_TEMPLATE_VIS char_traits; | ^ `NameString` is defined as `std::basic_string`, which is no longer possible. So redefine it as a `std::vector` instead. This requires a few adjustments in other places: adjusting the arguments for the `assign()` method, which for `std::vector` takes a begin and end iterator, instead of a begin iterator and a size, and replacing the `append()` method with an equivalent `insert()`. These changes have also been sent upstream [2]. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-remov= als [2] https://gitlab.isc.org/isc-projects/kea/-/merge_requests/2410 PR: 280696 Approved by: apevnev@me.com (maintainer) MFH: 2024Q3 net/kea/files/patch-src_lib_dns_name.cc (new) | 56 +++++++++++++++++++++++= ++++ net/kea/files/patch-src_lib_dns_name.h (new) | 11 ++++++ 2 files changed, 67 insertions(+) --=20 You are receiving this mail because: You are the assignee for the bug.=