[Bug 277708] net/cloud-init: new release: 24.1.1
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 277708] net/cloud-init: new release: 24.1.1"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 07 Apr 2024 15:13:40 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=277708 Joseph Mingrone <jrm@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrm@freebsd.org --- Comment #9 from Joseph Mingrone <jrm@freebsd.org> --- Thanks Mina. A few tweaks are required. For the net/cloud-init changes: 1. You need TABS (not spaces) after `=` in PATCH_SITES= and PATCHFILES+=. 2. PATCH_SITES= and PATCHFILES+= should come before the MAINTAINER= group. portclippy from ports-mgmt/portfmt is a helpful linter for things like this. 3. The build fails because the two patches you submitted upstream are already included in 24.1.4. So, in the end, we have to remove the PATCH_SITES= and PATCHFILES+= lines. net/cloud-init-devel looks good to me. For the commit logs, we should: 1. Include a reference to this PR 2. Use a TAB after 'Sponsored by:' 3. Include 'Approved by:' for the net/cloud-init update since someone else maintains the port. In this case, since two weeks have passed, we should use Approved by: andrey@bsdnir.info (maintainer, timeout). You can install the commit message template hook to make writing commit logs easier. See https://docs.freebsd.org/en/articles/committers-guide/#git-mini-primer-getting-started. -- You are receiving this mail because: You are the assignee for the bug.