From nobody Sat Sep 30 07:28:34 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RyJjZ5nDmz4vkCs for ; Sat, 30 Sep 2023 07:28:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RyJjZ2rBPz4vrZ for ; Sat, 30 Sep 2023 07:28:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696058914; a=rsa-sha256; cv=none; b=s3DeC8xg+uRMi2AOGPpQtaX7mBdRkQ7egKmn54g7yN+iqAtFgaQeXBBZ49YL4FTbuMh0fq /1NK4/vqJJpyo/0mRXyg1DQp0kr2iCfMxv1dWCyJnRIXJA+YPGSD56a2vTObqWMoI28lmA 3jA7k2mfYDcy1xgYKh3RL8Iw2GCURNefBa6P6Au/YT2GyKhGnQ2IvZOqpkV+F7TJeSQ5Wl eDKZ/QTIp4SoKoN56QnxuO/uQjuJCp7zaE7koJyGY6p/+l+1jBzGHvspSUirsMJRADN1Di s3SuQXdZmeyyk8cTx9WhC5YhRV1JQBGpPlLlGiWIezkrSeQ7jqP26fky15fY+Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696058914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IXRxgkspZ9qy/0aitMW9a+fUW6eZbJy2HFkGTngz5Es=; b=IYPiB4BxCYNGIiHYH40FGqtA4iLM24UMePSRnmHVnOnw4k8NiXURaeeVVfBDw4xSz9kFXI 7LJiPSqNj2RDcSPUlvU+saL6oAeEmzFT+E69GpRqgeYY8tWdOTYLiZFSfGPfMk9950bIKh K9ZNl+Qeex0mkJMkBc664afGOedNJLy6rilnS3Jesmz1X7TNQYW9uxT3ctRJc7eyAB7hUB r/Wrca//rmPy5cQPrVj/2AkZ0y+qX+ijcl4DUxrWd3rH5NYyU6aVDTquYfjlE4BYMemX1T 28z5OPPYMNtE1YsqxoxOdVqxSVI+/zwPhnclyUtBPKRsHAN1GAdv1A64MR03ew== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RyJjZ1qXtzf68 for ; Sat, 30 Sep 2023 07:28:34 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 38U7SYea003674 for ; Sat, 30 Sep 2023 07:28:34 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 38U7SYbN003673 for ports-bugs@FreeBSD.org; Sat, 30 Sep 2023 07:28:34 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274168] mail/postsrsd: `service postsrsd stop` return 1 Date: Sat, 30 Sep 2023 07:28:34 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: romain@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc flagtypes.name Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274168 Bug ID: 274168 Summary: mail/postsrsd: `service postsrsd stop` return 1 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: romain@FreeBSD.org CC: ports@bsdserwis.com CC: ports@bsdserwis.com Flags: maintainer-feedback?(ports@bsdserwis.com) Dear maintainer, When stopping the service, the `postsrsd_postcmd()` function in the rc-scri= pt attempts to remove the "/var/run/postsrsd" directory (redirecting stdout and stderr to /dev/null hiding any error here). But the directory contains the "postsrsd.pid" file and therefore `rmdir(1)` return the error code 1. This break configuration management systems that attempt to stop and start = the service: the stop action returning 1, the action is considered a failure. The rc subsystem checks that process with PID in the pid file correspond to= the actual service, so removing this directory is IMHO not required. As a consequence, I think we can remove that function completely. What do you think? --=20 You are receiving this mail because: You are the assignee for the bug.=