[Bug 274026] games/moonlight-embedded update to 2.6.0
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 274026] games/moonlight-embedded update to 2.6.0"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 23 Sep 2023 15:26:26 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274026 Robert Clausecker <fuz@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ports-bugs@FreeBSD.org |fuz@FreeBSD.org Status|New |Open --- Comment #5 from Robert Clausecker <fuz@FreeBSD.org> --- (In reply to Armin Zhu from comment #4) Hi Armin, Thank you for the update. There is no need to upload the changes in the project (i.e. attachment #245137). I just need the changes to the port (i.e. attachment #245136). What you should link to though is upstream's changelog so I can put it into the commit message. Please avoid long lines on bugzilla. As you see, they'll be broken up and your comment is hard to read. I strongly recommend that you submit these patches upstream. They seem to achieve sensible goals. Please avoid patches that just change whitespace, as they blow up the patch file with no benefit to the port. You also don't need to comment out code, you can just remove it. People can look at the patch to see what you changed. As for your patches to src/platform.c, we don't have /sys/... on FreeBSD, so I'm not sure why you patch code relating to these. Apart from that, your patch looks good and I'll be seeing that I can include it with my next batch. -- You are receiving this mail because: You are the assignee for the bug.