[Bug 271249] net-mgmt/yaf and net/libfixbuf: update to 2.13.0 and 2.4.2

In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 271249] net-mgmt/yaf: out of date"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: <bugzilla-noreply_at_freebsd.org>
Date: Wed, 20 Sep 2023 02:35:28 UTC

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271249

--- Comment #9 from Robert Clausecker <fuz@FreeBSD.org> ---
Do you have a src or doc bit?  If so, you can commit with approval from a ports
committer (use "Approved by:").  If not, please let me know and I'll help you
get these committed.

Patch largely looks good from my part.  Some questions:

 - you should switch to DISTVERSION from PORTVERSION if possible
 - if you commit, please make one commit for each of the two ports
 - is there any reason you use the EXTRA_PATCHES mechanism?  If not,
   please use regular patches (to generate them, copy the original
   files to $file.orig, then patch the files, then run "make makepatch")
 - do you have a changelog for the update?  If yes, please mention it
   in the commit message.

With these issues addressed, the patches are LGTM from my side.

-- 
You are receiving this mail because:
You are the assignee for the bug.