[Bug 273922] [NEW PORT] lang/emilua: Lua execution engine with support for async IO and flexible threading layout

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273922

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #3 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.

Please check the following items on your patch:

 - The indentation is a bit wonky.  You can use portfmt to auto-indent a port
   Makefile
 - Do the git hashes for the github dependencies correspond to tagged versions?
   If yes, it would be great if you could replace them with the tag names.
 - you should be able to use the /... syntax in GH_TUPLE to automatically have
   the dependencies moved into the right places, e.g.

       breese:trial.protocol:79149f6:trial_protocol/subprojects/trial-protocol

 - do not use REINPLACE_CMD for static replacements.  Instead, supply patch
   files.  You can use "make makepatch" to have them automatically generated,
   if you left copies of the originals with a .orig suffix.

 - Please expand pkg-descr to at least 3 lines.  Perhaps say a bit more about
   the project and what makes it interesting!

 - check if devel/cmake-core suffices for getting cmake.  This removes the need
   to build the entire cmake documentation as a dependency.

A build test on arm64 FreeBSD 13.2 fails as the luajit binary is for some
reason a dead link.  Not sure what the problem is.  Maybe a bug in
luajit-openresty's port?

Please check these issues and resubmit if appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.