From nobody Fri Sep 08 03:18:50 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RhhCb1gyWz4sXR4 for ; Fri, 8 Sep 2023 03:18:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RhhCZ4qklz4Z04 for ; Fri, 8 Sep 2023 03:18:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1694143130; a=rsa-sha256; cv=none; b=JSxwwZLbONPFes2xsb9hhwHwmGIv1LVScncaMZQJjKmFo7u3M9e4YpCeblSuja3ZVdzCIG E62vnPOznRreL6Vm7iTgRlXoxab8j/hTerNlh8LWodaqt/j/IAWEIZFpegBoWCvnMksvML k33BIapSekxdGbJTIidZIbfQwZriHtlUlacR6l3m4fd5ZDdZhb+Hcs2CKB7RyS5TaLvzJ1 8F9HFm+MrkcClWd0YGhHJTS9ktSBjYu2yFdlFz/2P3mSbcm3C/PuMPkQno/IxXOdpueLa9 ZNancsn8mpGsRtoHASfbH5Afmee/5QUrsIlS218REi7UCnFb1dJLY4T3aReEXA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1694143130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ueda0EAghp8cGeINaMFCiYr18lulnYz6XmMt1UYUJ1s=; b=WXGvtxWfwb0HPjQl4ayw2vm6C9f+6TDIoaN/enCLQ0vnGXIOIXQoLuG+MuB8O5aT5YdE8V y4vnBQ68/DPccXkjVRanlRaN2eRNf3iPmq869cTArRAkvwc5bLOyST4dypd8TS/mTFJ7wE H2myobJTeydZL0vxlUDVD07e2G+wQUuQ3uPX1hy1a+05ACsAyZGLS2/UobtnzBw380N0Kn sqDvj082iWB0NLaNVkUIpdKyDM6ObiLu3Ssr87lKGCL5DXCUKeRPy10MwN1l5XHdkvS0ST voD4I3N+LBMQOMlv0Oe8M1aew/KUc4nrgivjP0jNuW1WkIZvqHFa555Ayo3McA== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RhhCZ3vRbz9ld for ; Fri, 8 Sep 2023 03:18:50 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3883Io2N012847 for ; Fri, 8 Sep 2023 03:18:50 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3883IolH012846 for ports-bugs@FreeBSD.org; Fri, 8 Sep 2023 03:18:50 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 273461] [NEW PORT] irc/unreal current version of unrealircd 6.1.1.1 Date: Fri, 08 Sep 2023 03:18:50 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273461 --- Comment #2 from Robert Clausecker --- Thank you for your submission. TPlease remember to tick the "patch" box wh= en attaching patches so they can be viewed on bugzilla. This port looks very good already. Here are some notes on your port: - we got rid of "Created by" lines a while ago. New such lines will not be accepted. Please remove the line from the Makefile. - check if you can use USES=3Dlocalbase instead of manually adding localba= se to LDFLAGS and CPPFLAGS - ${DATADIR} should not be used for writable data or temp files. Please place such data in accordance with hier(7). For example, using /var/cache for caching and /tmp or /var/tmp (or a subdirectory of these) for temporary files may be a good idea. - why do you install source files with shared objects into the lib/unreal? Is this intentional? - for config files, please check if you can use the @sample mechanism (cf. =C2=A78.3 Porter's Handbook). If you don't use it, package updates may = kill the user's configuration changes. - upstream is no longer dead, is it? Is -fcommon still required? - ${MKDIR} should not fail if the directory already exists as it expands to mkdir -p. So || true is not required and could mask important errors. - please move the installation commands for docs into do-install-DOCS-on, = so they are only executed when DOCS is enabled - there's no reason to put doc subdirectory into DOCSDIR. It is already c= lear that DOCSDIR holds documentation. Please check these issues and resubmit if appropriate. --=20 You are receiving this mail because: You are the assignee for the bug.=