From nobody Wed Sep 06 10:55:18 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RgfRC3TL0z4s3s7 for ; Wed, 6 Sep 2023 10:55:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RgfRC1bhcz4MKp for ; Wed, 6 Sep 2023 10:55:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693997719; a=rsa-sha256; cv=none; b=uDpMg8lqQtoHctuW1iE0LPvtF7zMFIDFXkRE3GG32F7/hjTPyYe+or1We/RfQdrDJ/GeIS xr4Pf7laFB1sOhzi1n4xvEcbTdUo5B4gBIwu+9xzt+WT4McrM2J24Owv44o9L53yOYr7RH WXDbG8W/EHWpQv5EbZYoIC8avw9nOcBkis2Z7Gnr5FS+8J4HwRWt1gouPz+zrgif7lN1A1 uh9gZk3LdYsD2k7bQGtRGICyA4LMu85BwRERGyVQBiQUioRh6eDJSligUDRK1QAOMxEj3B tiqfe8faUnjT/7x7fSiWqKNLBvo5DCKiyamqBcldTiSajADJdMnH5doYOUBTNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693997719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3BvKMb8jdqybhPPNFzxcHi4ATkY+OSucyAr7vbHOih0=; b=HxkpgbFozHR8DzW8bzyXCL++jsV53gqudUEY9x1ix9KQ3eUj146MCwwikaTbCBL+uuF9/L 09cBC3bwgkoaV7+PuC+ZJ0x9WLcl5SLMcAG/3ctRTYF8iqsXoqckEb+1USPwSP34rdxGj9 cRf0OlLC0fEjIr46VeelmWAdpVTExsjkXmtjOvVSknWFiOQ9veOJWLseuWMaeuVo0bUePT R5j4crQISVCwlp2FqWsABw/h0uoJvXIsBqHKqVkRKqgqUws4ZmU6FzXmeR6RF1n7jpzd1V 9EPeF4IwS+QT7diZZZ2DM8333ZR03PlEYx+i6iht7sTuSGtGmh3L33r5VNd55g== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RgfRC0jm8z1Cq5 for ; Wed, 6 Sep 2023 10:55:19 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 386AtJir064198 for ; Wed, 6 Sep 2023 10:55:19 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 386AtJLt064197 for ports-bugs@FreeBSD.org; Wed, 6 Sep 2023 10:55:19 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 273595] net/samba413: back port security patches from 4.6.11 Date: Wed, 06 Sep 2023 10:55:18 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: michael.osipov@siemens.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: timur@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273595 Bug ID: 273595 Summary: net/samba413: back port security patches from 4.6.11 Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: timur@FreeBSD.org Reporter: michael.osipov@siemens.com Flags: maintainer-feedback?(timur@FreeBSD.org) Assignee: timur@FreeBSD.org Created attachment 244676 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D244676&action= =3Dedit Git-formatted patch pkg-audit nags me about: https://vuxml.freebsd.org/freebsd/441e1e1a-27a5-11ee-a156-080027f5fec9.html I tried to produce a reasonable patch for 4.13.x for the time being. Started from https://www.samba.org/samba/history/#4.18.5 using 4.16.11 as a foundat= ion based on: https://www.samba.org/samba/history/samba-4.16.11.html. Cloned the repo and checked out v4-16-stable, search for all commits with t= hose CVEs: # git log --oneline "--grep=3DCVE-2022-2127" "--grep=3DCVE-2023-3347" "--grep=3DCVE-2023-34966" "--grep=3DCVE-2023-34967" "--grep=3DCVE-2023-3496= 8" 1809843614b CVE-2023-34968: mdssvc: return a fake share path cecd415a0ab CVE-2023-34968: mdscli: return share relative paths d6b9c5234ff CVE-2023-34968: mdssvc: introduce an allocating wrapper to sl_pack() 0fdfc85f28a CVE-2023-34968: mdssvc: switch to doing an early return 34f9f1b37ec CVE-2023-34968: mdssvc: remove response blob allocation 739f72a0703 CVE-2023-34968: rpcclient: remove response blob allocation 7bbaa191be6 CVE-2023-34968: smbtorture: remove response blob allocation in mdssvc.c 82cc2a422db CVE-2023-34968: mdscli: remove response blob allocation 3636b54616e CVE-2023-34968: mdscli: use correct TALLOC memory context when allocating spotlight_blob 8c95f7ae6b3 CVE-2023-34968: mdssvc: add missing "kMDSStoreMetaScopes" dict = key in slrpc_fetch_properties() b09e22cfc79 CVE-2023-34968: mdssvc: cache and reuse stat info in struct sl_inode_path_map 843ec381de3 CVE-2023-34968: lib: Move subdir_of() to source3/lib/util_path.c 5b4353cc60b CVE-2023-34967: mdssvc: add type checking to dalloc_value_for_k= ey() 92d014bc44b CVE-2023-34967: CI: add a test for type checking of dalloc_value_for_key() cb6f3e22024 CVE-2023-34966: mdssvc: harden sl_unpack_loop() 01cf3cf7a83 CVE-2023-34966: CI: test for sl_unpack_loop() 2eabbe31f64 CVE-2022-2127: ntlm_auth: cap lanman response length value 5c6fe5a491b CVE-2022-2127: winbindd: Fix WINBINDD_PAM_AUTH_CRAP length chec= ks 1dd3ae281b9 CVE-2022-2127: s3:winbind: Move big NTLMv2 blob checks to parent process Then branched off v-4-13-stable and started to cherry pick from 1dd3ae281b9= to 1809843614b. There were a few conflicts I had to resolve. Looking at the co= de in 4.16.x and 4.13.x I hopefully made the right decisions to pick hunks and produced a series of patches with "git format-patch". Attached you will fin= d a Git-formatted patch with the necessary changes in the Makefile as will as t= he back-ported security fixes in EXTRA_PATCHES. Please try to reproduce the patches and check whether I have resolved the conflicts correctly. Poudriere pending... --=20 You are receiving this mail because: You are the assignee for the bug.=