From nobody Thu Oct 19 17:25:47 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SBF3v2Y35z4xgLP for ; Thu, 19 Oct 2023 17:25:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SBF3v0qN1z3PXC for ; Thu, 19 Oct 2023 17:25:47 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1697736347; a=rsa-sha256; cv=none; b=f8gk5DtfIddpUTK2Kcs//PNLZ0TMuMnvLU5tzUd3IZ4jtt1crkq+j9k9/wqnwA1Cpn0/08 r+9Dz4vaLpj++zYopf+gzyoMqwsL4e/OSdFHoU1ttvQe8UqZJo+UBcN6tqg/FReo1m77To ANawUHjWD/Op23FJ8I4MRvHesgxOvM8KMCFq0qTYqlXgDmoU4R2DcFJqTLB5GjY450gDb/ L1ibv/oriSpfqHbVPXbkySiM4p1byrsRRNzFOvpktdJt3Xx8tzVH0WjcSAARqlitjpyyg9 pNXGZfEeMbRC728GXA8yffqZpV5n/M4sFnbYnaK0amM4XUUt0HHEaPdzTaHpFA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1697736347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8S1bnveIyR5AjJZGde8pdUh+X3dG/XYGSw1iPuIoAMY=; b=A/+A91TNhVUjIpW2I492LAPoXzf+WgtIohtatYZ5ndWJgeNELUf0a4ER3O/0nqtzYN2kz1 XjOf4IdzJM/ZdSc50xVUun20OEoqOLATmD6izz9MRaY9DSoaO7uCE/Ur0PQe7TZ37HTAGi 8H4gLixQrgT3uZbxQQitGzveNc1719qtq16JS0sGhOvFJPKj+KhXeeOb/o6Thyqun2sCPx Tz1x09R9DPPJQMVhxz1Z/BV2LWww0PPVPhbRQBSdg21kHG1GX94FB3j6Lrq3H+7gp8liGE Yo1GfTrdRCzGL9LY70tBomnZRtMrrvGsgXAbANHW2qJjJNfaSsiExBPH5s9psw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SBF3t71yXzyh8 for ; Thu, 19 Oct 2023 17:25:46 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 39JHPkfB007590 for ; Thu, 19 Oct 2023 17:25:46 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 39JHPkh2007589 for ports-bugs@FreeBSD.org; Thu, 19 Oct 2023 17:25:46 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 274595] net-p2p/monero-cli: new build option added Date: Thu, 19 Oct 2023 17:25:47 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fuz@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D274595 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open Assignee|ports-bugs@FreeBSD.org |fuz@FreeBSD.org --- Comment #1 from Robert Clausecker --- Thank you for catching that. As per =C2=A7 13.14.4 Porter's Handbook, -mar= ch=3Dnative must not be enabled by default. Your patch is good, but please rename the option to NATIVE (this is the standard name in ports for such an option, you can omit NATIVE_DESC as it is provided in bsd.options.desc.mk) and make it enable -march=3Dnative with th= e flag being off by default. I think it might be possible to avoid the patch to CMakeLists.txt by using NATIVE_CMAKE_ON=3D -DARCH=3Dnative NATIVE_CMAKE_OFF=3D -DARCH=3Ddefault but I'm not super familiar with cmake, so please check for yourself. Also please increment PORTREVISION by only 1 for each update. --=20 You are receiving this mail because: You are the assignee for the bug.=