[Bug 274383] mail/aerc: Update to 0.16.0 and take maintainership

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274383

--- Comment #2 from Robert Clausecker <fuz@FreeBSD.org> ---
Is there a changelog for this update?

Instead of moving the Makefile, you can set the MAKEFILE variable to the actual
name of the Makefile.

You might want to change the port so it uses the GO_MODULE mechanism to have
the Go tooling download the required files (if that works in this case).  This
would remove the need for all the complicated handling of extra dependencies.

The port currently ignores CFLAGS and CPPFLAGS.  Make sure it respects them.  I
can see this as the output has

    cc -O2 -g  -o colorize filters/colorize.c

without the usual -fstack-protector-strong etc.  This can perhaps be fixed by
invoking make properly (and please do it separately for build and install if
possible):

    (cd ${WRKSRC} && ${DO_MAKE_BUILD} ${ALL_TARGET})

and later to install,

    (cd ${WRKSRC} && ${DO_MAKE_BUILD} ${INSTALL_TARGET})

If you have USES=gmake, this automatically picks GNUmake.

Furthermore, make sure installed binaries are stripped.  stage-qa complains:

====> Running Q/A tests (stage-qa)
Warning: 'libexec/aerc/filters/colorize' is not stripped consider trying
INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'libexec/aerc/filters/wrap' is not stripped consider trying
INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: you might not need LIB_DEPENDS on libnotmuch.so

Also please set VERSION in MAKE_ARGS so the port doesn't try to invoke git to
find the version (this frequently goes wrong if the ports tree is managed via
git; go figure).  In fact, since we build the main binary via USES=go's default
do-build rule, you should also carry over all the other bits that go into
GO_BUILDFLAGS.

-- 
You are receiving this mail because:
You are the assignee for the bug.