From nobody Fri Oct 06 18:08:30 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4S2GdC0LKlz4w3Qv for ; Fri, 6 Oct 2023 18:08:31 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4S2GdB6Rkfz3FRK for ; Fri, 6 Oct 2023 18:08:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1696615710; a=rsa-sha256; cv=none; b=an8Qg1c3V1NU/AzRScfNQZTi6JXReo/ABDy/Nu6bxq2EhgyzpZLm3kimAIIQYTbXhMdvu3 jNAMJzMurV+hfc+OlyEdwmEAQUeCH6umljwIhNkDQ+/TgxosoN2aGwGcEq21EEHjYsHEgD q+EWfrP/iUZt0t1nD/QjVY5ajV4aaDs+vaVI0mqjin4RMBSKVyMWL4jJtrOzABxIAaXMn9 VP+nEQppmSaGuzoLi3jWJvBSlcveToW/49sSuWM8PoqEGrOQYpBA4mSK2kbVxOeb6tP6tl gXP5XSgmsaQQ/13mc072BTGfuqx2CT9sETCA+sGVGJSbsdUO27Hq1icnOTf0VQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1696615710; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CORLzJQGh+hgjmYiP8JtDJUJtiAbWIKZwSjCNs2A+B0=; b=sHtkphCsk0kuQ5gyWpAPrNpDj/o0rh2QYI4f972EPhOseQFy+5WcvF3XJ5jn6xebUeWY3H NCd9H34E+/dMrwXAGEQo1Q3OvDbURWWrofS/kjI8UW9SDfhhp8wxVKjnieEw/HofRn+u4D XTMH1xFuu1tdoHsPzeE53X1ZCv2ShS8K0lDJ3D04Yt7K2Rx8UrBTz9J13d4npk5BinKQn7 dCLInLVchV+QIQeF0p8vLqGFDh66dv52aSASx6TFFvlRdE9Od9BaoUgIJTYWrY7NZqt3Kl 4/ZXJxBEwfxoiKcrEH1TxQ8uMDizU8uiFyfNYr1pN/FghXuVIcwYG48SdBd1qw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4S2GdB5NqqzyTf for ; Fri, 6 Oct 2023 18:08:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 396I8U1D089676 for ; Fri, 6 Oct 2023 18:08:30 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 396I8U64089674 for ports-bugs@FreeBSD.org; Fri, 6 Oct 2023 18:08:30 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 262032] [NEW PORT] devel/xnvme: Cross-platform libraries and tools for NVMe devices Date: Fri, 06 Oct 2023 18:08:30 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: feature X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D262032 --- Comment #5 from Robert Clausecker --- Other things you should check: - general policy is to install all shell completion files, even if the corresponding shells are not installed. Do not add dependencies on the shells you install completion files for. See =C2=A7 6.33 Porter's Handb= ook for details. Shell completion files can be made optional, but that's on= ly really needed if they are of substantial size. - add an option TEST and only install test binaries if this option is set. It seems like these binaries are not required for normal use, but feel free to correct me if I am wrong. - same thing applies to examples (with option EXAMPLES) - if you expect the library to be used separately from the tools, it might make sense to split the port into one port that only installs libraries = and one that only installs tools and depends on the library port. - the port needs to set USE_LDCONFIG=3Dyes as it installs shared libraries. - you may want to create a separate port for the Python bindings if desired - I see that you have extensive additional documentation. It would be gre= at if you could add a DOCS option and install that documentation if it is enabled. --=20 You are receiving this mail because: You are the assignee for the bug.=