[Bug 273753] [exp-run] Against llvm-17-update branch on GitHub

From: <bugzilla-noreply_at_freebsd.org>
Date: Sat, 11 Nov 2023 09:47:28 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273753

--- Comment #66 from commit-hook@FreeBSD.org ---
A commit in branch main references this bug:

URL:
https://cgit.FreeBSD.org/ports/commit/?id=660b01aa59ee1266ce0faf5718dc5c90abfa4f31

commit 660b01aa59ee1266ce0faf5718dc5c90abfa4f31
Author:     Dimitry Andric <dim@FreeBSD.org>
AuthorDate: 2023-11-11 09:35:15 +0000
Commit:     Dimitry Andric <dim@FreeBSD.org>
CommitDate: 2023-11-11 09:46:07 +0000

    www/qt6-webengine: fix build with libc++ 17

    Building www/qt6-webengine with libc++ 17 results in the following
    compile errors:

      In file included from gen/base/base_jumbo_2.cc:7:
      In file included from
./../../../../../qtwebengine-everywhere-src-6.5.3/src/3rdparty/chromium/base/check.cc:17:
      In file included from
../../../../../qtwebengine-everywhere-src-6.5.3/src/3rdparty/chromium/base/debug/crash_logging.h:16:
      In file included from
../../../../../qtwebengine-everywhere-src-6.5.3/src/3rdparty/chromium/base/strings/string_number_conversions.h:15:
      In file included from
../../../../../qtwebengine-everywhere-src-6.5.3/src/3rdparty/chromium/base/containers/span.h:18:
     
../../../../../qtwebengine-everywhere-src-6.5.3/src/3rdparty/chromium/base/containers/checked_iterators.h:241:8:
error: no template named '__is_cpp17_contiguous_iterator'; did you mean
'__libcpp_is_contiguous_iterator'?
        241 | struct
__is_cpp17_contiguous_iterator<::base::CheckedContiguousIterator<T>>
            |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            |        __libcpp_is_contiguous_iterator
      /usr/include/c++/v1/__iterator/iterator_traits.h:476:8: note:
'__libcpp_is_contiguous_iterator' declared here
        476 | struct __libcpp_is_contiguous_iterator : _Or<
            |        ^

    This is because the copy of chromium in qt6-webengine is missing an
    upstream fix for recent libc++ changes, in particular:

     
https://chromium.googlesource.com/chromium/src/+/9bfbbffdba73668fdb483e5a850911d2b64c35d7

    and its dependency:

     
https://chromium.googlesource.com/chromium/src/+/5b5551edd3961481e617e510276b9f015a35b861

    Apply these patches to work around the compile error.

    PR:             273753
    MFH:            2023Q4

 ...mium_base_containers_checked__iterators.h (new) | 75 ++++++++++++++++++++++
 1 file changed, 75 insertions(+)

-- 
You are receiving this mail because:
You are on the CC list for the bug.