[Bug 274813] www/elog: Revive port

From: <bugzilla-noreply_at_freebsd.org>
Date: Thu, 02 Nov 2023 21:29:37 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274813

Robert Clausecker <fuz@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fuz@FreeBSD.org

--- Comment #1 from Robert Clausecker <fuz@FreeBSD.org> ---
Thank you for your submission.  Here are some comments:

 - are the UID/GID values the same ones the port had before it was removed?
   If not, check if they can be made the same.
 - CC=c++ is our default setting, but is not correct to hard code.  Ports must
   obey whatever value CC is set to.  I recommend you change the Makefile patch
   to just remove any assignment to CC, CFLAGS, etc.  If you do that, the
   Makefile should grab the right values from the environment.  Failing that,
   you may be able to add CC=... to MAKE_ARGS.
 - why is the elog user needed?  I don't see any file owned by it nor an rc.d
   script or similar?  Please either remove the elog user/group or explain why
   it exists and how it is used.
 - check if @sample should be used with the configuration file you install.
 - move the installation steps for the documentation to target
do-install-DOCS-on
   so they are only run when DOCS is enabled

Port looks ok otherwise.  Will proceed with a build test once you address these
issues.

-- 
You are receiving this mail because:
You are the assignee for the bug.