[Bug 271374] emulators/mame-0.254 fails to build on {arm64,amd64,i386}-14-CURRENT

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271374

--- Comment #27 from Alastair Hogge <agh@riseup.net> ---
(In reply to Robert Clausecker from comment #26)

> Looks cool!  Here are some things I found:
>
>  - do-install-DEBUG-on and do-install-DEBUG-off do the same thing and can be merged; just put the commands into do-install

Are you sure? I am not. MAME builds "mamed" with DEBUG, and "mame" without
DEBUG. Do you think we should just install with the d suffix?

>  - I recommend that you keep the mention of armv7 in the comment above LDFLAGS.
>    Else a future maintainer might test on amd64 and find that it is not needed,
>    breaking the port once more (you won't believe how often that happens).

Ohh good point. Will add/restore. Thanks.

>  - the conditionals for the QTDEBUGGER option are commented out.

Yeah, the patch is still WIP (Work In Progress), and I was lazy and left some
crumbs lying around, my bad.

> Is this correct?  You can rewrite them like such:
>
>     QTDEBUGGER_MAKE_ENV= USE_QTDEBUG=1
>     QTDEBUGGER_USES= qt:5
>     QTDEBUGGER_USE= qt=core,gui,widgets,buildtools:build,qmake:build

Oh that is that far more elegant, totally happening, thanks.

>  - in OVERRIDE_CC for FreeBSD > 14, you should not use COMPILER_TYPE as it could
>    be gcc.  Just write e.g. clang++${LLVM_VERSION}.

Ah yes, thanks, again more crumbs.

>  - check if you can use DISTVERSION instead of PORTVERSION as per policy

Good idea, will do.

>  - would it make sense to make TOOLS=1 a port option so people can get a leaner mame if they want?

Farken oath I think it would (I think it is only 3 more binaries), great idea,
totally happening.

Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.