From nobody Sat May 27 08:17:12 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QSvls0n74z4Wj7k for ; Sat, 27 May 2023 08:17:13 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QSvlr5Vq6z3J1R for ; Sat, 27 May 2023 08:17:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685175432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2y6ebqXhu6jwxEYDH6279+eGos9ykjBY3CDLeJA+P6w=; b=sEpCeIdAUgTDa1vlNHYQlEhKOy0P841deQ23pkMEgIlEMufl06tHU3ZS/J0HE1MP1FgJoL otbYFKGtp6GZ5yqHii96E3Ig6K7PWseAIyy++3w5GsmnOmo/tIRriv7zGkbY3xfYu8wROj hqRYMY5lxxQ990iU9nOEYSwMXZSSR7FJuB4PX5jlS/Dfd+IAP1eBYy8JyIzW/xQ8Ic+Sk5 poloFHjtk3qTMVIWDSrVXybivLGZy+QRfgD5JTHZEK34LM3O54pFr6YZy54suwFCl07h4w lHkSmYXodZXRQ0ZSFp8WOLORonJ3TK2e7e2GWWK6w3wSWy+gUCtcvI9vkcG/lQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685175432; a=rsa-sha256; cv=none; b=xW1zGAXg/OBwTlVzQR8WtFI94v4hMWVN+1/Z2TselYeHIG42UTkKdQXhQxoe6WlsAZv7aa SY2btlOG6pL/4lnhsEih4YSus5QMV7CDJ1JRXe6Xn2E+olbNSsRk34d1wtxxuyiPn41epp uoPoo0dWwSUSVyaPIXqKZIHsQefyRQO7nr3O4dAr2d8eNoB1MV9pgYrbKL2edcumMWgdYJ kRoNBPn58nZiUX3C/zXfFMw6ZdlYEFbxOLgX+pC60Kk0l7DhABrwq1nk9xGmMGdvlNDu45 x3jjhj7YNj6hA1L8BX3YPSMgPak2Bd7i1wn7cDHBxU/jcMKAjcXSBm25TX+Ahw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4QSvlr4ZtQzh5D for ; Sat, 27 May 2023 08:17:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 34R8HCqt016178 for ; Sat, 27 May 2023 08:17:12 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 34R8HChD016177 for ports-bugs@FreeBSD.org; Sat, 27 May 2023 08:17:12 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 271374] emulators/mame-0.254 fails to build on {arm64,amd64,i386}-14-CURRENT Date: Sat, 27 May 2023 08:17:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271374 --- Comment #26 from Robert Clausecker --- (In reply to Alastair Hogge from comment #25) Looks cool! Here are some things I found: - do-install-DEBUG-on and do-install-DEBUG-off do the same thing and can be merged; just put the commands into do-install - I recommend that you keep the mention of armv7 in the comment above LDFL= AGS. Else a future maintainer might test on amd64 and find that it is not nee= ded, breaking the port once more (you won't believe how often that happens). - the conditionals for the QTDEBUGGER option are commented out. Is this correct? You can rewrite them like such: QTDEBUGGER_MAKE_ENV=3D USE_QTDEBUG=3D1 QTDEBUGGER_USES=3D qt:5 QTDEBUGGER_USE=3D qt=3Dcore,gui,widgets,buildtools:build,qmake:build - in OVERRIDE_CC for FreeBSD > 14, you should not use COMPILER_TYPE as it could be gcc. Just write e.g. clang++${LLVM_VERSION}. - check if you can use DISTVERSION instead of PORTVERSION as per policy - would it make sense to make TOOLS=3D1 a port option so people can get a = leaner mame if they want? --=20 You are receiving this mail because: You are the assignee for the bug.=