[Bug 269566] New port: lang/mlkit

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=269566

--- Comment #6 from Robert Clausecker <fuz@FreeBSD.org> ---
(In reply to serpent7776 from comment #5)

Thank you for your updated patch.  Here are some questions I have:

 - it's USE_GCC, not USE_gcc.  I can fix that on commit.
 - The test target is not run by default and should not be made dependent
   on an option.  It's purpose is to permit testing the port at build time.
 - Your port now no longer installs any test files, not even if the TEST option
   is set.  So why is this option provided?  Your original patch installed a
   bunch of test files, so I'm a bit confused as to what your intent is.  If
   your intent was to install test files when "make test" is executed, please
   don't do that.  Instead install them if the TEST option is provided, perhaps
   in a separate install target (such as do-install-TEST-on, which is run only
if 
   the TEST option is enabled).
 - please don't hard code a path to bash as the configure shell.  I can patch
   this to just say CONFIGURE_SHELL= bash.

Will proceed with a build test once I have a response to these questions.

-- 
You are receiving this mail because:
You are the assignee for the bug.