[Bug 271230] net-mgmt/py-pysmi: Update to 1.1.13

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271230

John W. O'Brien <john@saltant.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #241957|0                           |1
        is obsolete|                            |
 Attachment #242088|                            |maintainer-approval+
              Flags|                            |

--- Comment #2 from John W. O'Brien <john@saltant.com> ---
Created attachment 242088
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=242088&action=edit
net-mgmt/py-pysmi: Update to 1.1.13

Thank you for your review.


 > - we usually prefer downloading python packages from PYPI for consistency,
 >   though using other master sites is permitted.

Changed from GITHUB to PYPI, converting from GH_ACCOUNT to DISTNAME to follow
temporary name change while PEP-541 request is in-progress [0]. Also, removed
CHANGES.rst, THANKS.txt, and TODO.txt docs, because they are not published in
the sdist.

On this topic, the Python Ports Policy needs to be updated for consistency.

"Ports SHOULD use MASTER_SITES=CHEESESHOP if a Python package is registered on
PyPI"

% find /usr/ports/ -depth 3 -name "Makefile*" \
    | xargs grep -Eo "PYPI|CHEESESHOP" -h \
    | sort \
    | uniq -c
   7 CHEESESHOP
3541 PYPI


> - please use DISTVERSION over PORTVERSION if possible

This is quite an esoteric nit to pick. A reasonably close reading of all three
applicable document collections (the Porter's Handbook, /usr/ports/Mk/*, and
the Python Ports Policy) leads me to the conclusion that DISTVERSION and
PORTVERSION are totally interchangeable under the circumstances, and that the
tie-breaker in favor of DISTVERSION is pretty far down the decision tree.
Established precedent supports my initial patch.

% find /usr/ports/ -depth 3 -name "Makefile*" \
    | xargs grep -Eho "^(PORTVERSION|DISTVERSION)" \
    | sort \
    | uniq -c
11441 DISTVERSION
22980 PORTVERSION

Changed from PORTVERSION to DISTVERSION because I need to appeal to the widest
possible set of people with commit bits.


> - instead of setting GH_TAGNAME, just set DISTVERSIONPREFIX=v

OBE


> - we don't ship Python 3.6 anymore, so you can leave out the lower
>   version limit for USES=python

The specification of supported Python versions is taken directly from upstream
along with those of the build system [1] and other dependencies [2].

No change.


> - is devel/py-poetry-core truly only needed at build time?  If it is
>   also required at runtime, please also add it to RUN_DEPENDS.

Why do you ask?


[0] https://github.com/etingof/pysnmp/issues/429
[1] https://github.com/lextudio/pysmi/blob/v1.1.13/pyproject.toml#L43
[2] https://github.com/lextudio/pysmi/blob/v1.1.13/pyproject.toml#L27-L30

-- 
You are receiving this mail because:
You are the assignee for the bug.