From nobody Sat Mar 25 21:34:01 2023 X-Original-To: ports-bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4PkXQK5mntz41kkc for ; Sat, 25 Mar 2023 21:34:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4PkXQK3CXdz3wnZ for ; Sat, 25 Mar 2023 21:34:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1679780041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PBcd64O1dXXE2Q1vdVrMhaswKI3tDur2jDwAaZwBOtA=; b=pi8Ost1IcApaZcvWnLKZD7HYiHGf4fxFUiS6XFXucdjTnLgJIuASf/Dpo2PbVUDwEOpOTF r/Nq+4DI0iRBdVexWfmVQfs4LuEJMfOc1yGliZxqUoIOm+qUJpvVI8LVBNNVjlJJ2dgUI1 w5vuWVH04XjUzh7/Qkh3Zk0R4010cIwVQod5iAzXu9tFcWLzJv8N6mIBdr2yniFiD4/Cfy e/LKW2gVcFxaAEzVgwVo/T7VKd+UEXaTLtsYOTBiw9rTtHkNgOu8DwaWYoDcJhXN6aBtvK rB8Dpuu2DvHek2X9FftDw41gxqRhTIIyU/qAB9o8/W049S16sEXHTtMrmK0jjw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1679780041; a=rsa-sha256; cv=none; b=W87wXRhd/uXYFbde0osDw4Aid4iyvV3gXbVQC7JStD4dKsEUd/7gxiflXvBR9SjfhTbveY CSenYKy5/1d1fYugMOVbTReHoZr4e5bWmCSYDzIEDvdj62CvRsciRqgR1TnVuBDcuWEt0B 7fHNyoBsa86RyU23E3VR65f5WG2wqmfbmdE/o7lj1aA+g/hEjst53PknqWC/nD0oTnhnap EgBnqFYs0HMkwFQVs7cHRN6m5KEnqtBSkJsD/shSRmGs+khSr1FNFsEbziGVkyW8RI55g7 nmNSCVaAG+ae3JJGNp9GRpZji0twFe2uXZ1wiW4XBcRz3Gqa+5Zh9Uj0kfwG+A== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4PkXQK2HtrzFst for ; Sat, 25 Mar 2023 21:34:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 32PLY1uc088779 for ; Sat, 25 Mar 2023 21:34:01 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 32PLY1Ih088778 for ports-bugs@FreeBSD.org; Sat, 25 Mar 2023 21:34:01 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 269566] New port: lang/mlkit Date: Sat, 25 Mar 2023 21:34:01 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: fuz@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc bug_status Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Ports bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-ports-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D269566 Robert Clausecker changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fuz@FreeBSD.org Status|New |Open --- Comment #1 from Robert Clausecker --- Thank you for your contribution! Here are some issues I found: Instead of adding the license file to PORTDOCS, set LICENSE_FILE=3D ${WRKSRC}/path/to/the/license. If there are multiple licenses, each license needs to be configured and its LICENSE_FILE set up. Please set DISTVERSION instead of PORTVERSION unless DISTVERSION doesn't wo= rk for you. Why is the port "ONLY_FOR_ARCH=3Damd64"? Please add ONLY_FOR_ARCH_REASON to explain the reason for this restriction. You having only tested the port f= or this architecture is not sufficient reason to restrict it, you need to know that it will not work on other architectures. Please include bsd.port.option.mk only if your makefile needs to evaluate option-specific macros. This doesn't seem the case with your makefile. Why did you set GH_TAGNAME to a git commit? The USE_GITHUB mechanism is capable of working with tag names. You should simply set DISTVERSIONPREFIX= =3D v and leave out GH_TAGNAME. This will do the right thing. I also see that the Makefile is for the previous version. Please check if = you can update it to the most recent version. I also noticed that the variables are in the wrong order. Please fix the o= rder in accordance with the Porter's Handbook. The portclippy utility can help = you with that. Are you sure CONFIGURE_SHELL is needed? Are you sure DISABLE_MAKE_JOBS is needed? Each installed file must only be listed once. Either in PORTDOCS/PLIST_FIL= ES or in the pkg-plist file. Do not list files twice. Check if you can make the demo and test files conditional on an option. Th= ere are standard option names TEST and EXAMPLES for these. Please check these issues. I can proceed with a build test once you have addressed them. --=20 You are receiving this mail because: You are the assignee for the bug.=