[Bug 268972] net-mgmt/collectd5: update varnish dependency and modify nut dependency

From: <bugzilla-noreply_at_freebsd.org>
Date: Tue, 07 Mar 2023 22:52:54 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268972

--- Comment #8 from Krzysztof <ports@bsdserwis.com> ---
OK, so I am a little confused. 

I've made such checking (1):
.if ${PERL_LEVEL} >= 500809
CGI_RUN_DEPENDS+=       p5-CGI>=0:www/p5-CGI
.endif

then in logfile there is:
[00:01:00] ====> Running Q/A tests (stage-qa)
[00:01:01] Notice: You have some Perl modules as dependencies but you do not
have devel/p5-Module-CoreList installed, the perlcore QA check gets better
results when using it, especially with older Perl versions.

OK, so I've changed Makefile to (2):
.if ${PERL_LEVEL} >= 500809
CGI_RUN_DEPENDS+=       p5-Module-CoreList>=0:devel/p5-Module-CoreList \
                        p5-CGI>=0:www/p5-CGI
.endif

then in logfile there is:
[00:00:59] ====> Running Q/A tests (stage-qa)
[00:01:00] Warning: www/p5-CGI was in Perl CORE.  Check with `corelist CGI 0`
and `corelist -a CGI` if it should be conditionally added depending on
PERL_LEVEL
[00:01:01] Warning: devel/p5-Module-CoreList is present in Perl CORE.  Check
with `corelist Module::CoreList 0` and `corelist -a Module::CoreList` if the
dependency is really needed or if it should be conditionally added depending on
PERL_LEVEL

So which checking I should use? (1) or (2) ?

And I'm not sure if checkinng PERL_LEVEL is correct. According to corelist CGI:
Data for 2021-01-23
CGI was first released with perl 5.004, deprecated (will be CPAN-only) in
v5.19.7 and removed from v5.21.0

So how to check PERL_LEVEL correctly for p5-CGI?

-- 
You are receiving this mail because:
You are the assignee for the bug.