[Bug 271954] [NEW PORT] x11-wm/emwm Enhanced Motif Window Manager
- In reply to: bugzilla-noreply_a_freebsd.org: "[Bug 271954] [NEW PORT] x11-wm/emwm Enhanced Motif Window Manager"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 30 Jun 2023 16:12:42 UTC
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271954
Stephan Lichtenauer <stephan@lichtenauer.co.za> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #242737|0 |1
is obsolete| |
Attachment #243082| |maintainer-approval+
Flags| |
--- Comment #3 from Stephan Lichtenauer <stephan@lichtenauer.co.za> ---
Created attachment 243082
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=243082&action=edit
Updated patch including fixes for all comments.
Thank you very much for your feedback, please find updated patch attached.
> instead of EXTRACT_SUFFIX, add USES=tar:xz
Done.
> please hard-break pkg-descr to 72 or 80 columns.
Done.
> please add a blank line before the LICENSE block. You can use portfmt
to auto-format the port.
Reformatted with portfmt.
> do not hard code /usr/bin/install. Instead, use the INSTALL_... macros
described in ยง 5.17.1 Porter's Handbook.
Changed and also fixed pkg-plist to include the directories.
> please set the author field in your patch to your true email address and
name. Also check if you can set name and surname in bugzilla to make it
easier for us to enter correct metadata into version control.
Done.
> make sure to hook the new port into x11-wm/Makefile.
Done.
--
You are receiving this mail because:
You are the assignee for the bug.